1226890 - Nonvirtual C++ method overrides aren't being recognized as overrides

Status: RESOLVED WONTFIX

(Webtools Graveyard :: DXR, defect)

Description

[Tom Klein]

For something like

class B { void f(); };
class D : public B { void f(); };

The context menu for the f's should show overrides or overriden, and searching for overrides: or overridden: should return results.

If anybody knows of examples of nonvirtual overrides in mozilla-central (or how one might go about finding them) please post them here for testing - thanks.

Comment 1

[Tom Klein]

Just a note (I'm not working on this): the clang ast only tracks *virtual* overrides for its overridden_methods list:
CXXMethodDecl::addOverriddenMethod http://clang.llvm.org/doxygen/DeclCXX_8cpp_source.html#l01566
so it looks like the non-virtual overrides aren't going to come for free.

Comment 2

[Erik Rose [:erik][:erikrose]]

It sounds like that's a pretty unusual corner case, so I'm not too worried about it. Thanks for noting it, though.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

DXR is no longer available. Searchfox is now replacing it.
See meta bug 1669906 & https://groups.google.com/g/mozilla.dev.platform/c/jDRjrq3l-CY for more details.