1226938 - Update clang-format binaries for mach

Status: NEW

(Firefox Build System :: General, defect)

Description

[Biru [:poiru]]

mach currently downloads an outdated version of clang-format, which lacks many of the Mozilla style improvements I've worked on (see bug 961541).

Right now[0], we download the binaries from https://people.mozilla.org/~ajones/clang-format/, which seems questionable. gps, do we have a better place for storing binaries?

[0]: https://dxr.mozilla.org/mozilla-central/source/tools/mach_commands.py#362

Comment 1

[Biru [:poiru]]

Perhaps we should create something like http://archive.mozilla.org/pub/gecko-tools/?

Comment 2

[Gregory Szorc [:gps]]

I'm almost positive I raised objections to the people.mozilla.org URL when I initially reviewed this code. By all means we should establish something more official. 

archive.mozilla.org certainly seems reasonable.

Other build peers have done more with uploading tools than I have. They might be able to suggest an existing and appropriate location, perhaps even tooltool.

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

What upstream clang-format minimum version is usable for Mozilla style formatting? Perhaps we could add a prompt to tell the user to install via the system's package manager so that we don't need to host the binaries ourselves?

Comment 4

[Gregory Szorc [:gps]]

The binaries should be uploaded to tooltool. See https://wiki.mozilla.org/ReleaseEngineering/Applications/Tooltool#How_To_Upload_To_Tooltool

Comment 5

[Biru [:poiru]]

(In reply to Ting-Yu Lin [:TYLin] (UTC+8) from comment #3)
> What upstream clang-format minimum version is usable for Mozilla style
> formatting? Perhaps we could add a prompt to tell the user to install via
> the system's package manager so that we don't need to host the binaries
> ourselves?

We have to use a consistent version of Clang-Format as its output changes from version to version. I haven't had much free time lately, but I'll try to get our version of Clang-Format upgraded in the near future.

Sorry for the (very) late reply!