1227068 - [Messages] Increase the chunk size that we display when scrolling up in a conversation

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
1. Open a big conversation.
2. Scroll up.
=> Notice that the messages are displayed 10 by 10 only. Moreover, notice this flickers (this is bug 1189227)

In this bug, we want to display more messages at once. From my test it also makes the flicker a lot less visible, but I don't know why.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] julienw:1227068-fix-chunk-size > mozilla-b2g:master

Comment 2

[Julien Wajsberg [:julienw]]

Comment on attachment 8690751 [details] [review]
[gaia] julienw:1227068-fix-chunk-size > mozilla-b2g:master

Hey, what do you think of this ?

From my tests it also make bug 1189227 disappear ! (tested on Aries and Flame)

Comment 3

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8690751 [details] [review]
[gaia] julienw:1227068-fix-chunk-size > mozilla-b2g:master

Looks great!

I think it's safe and important enough to be uplifted :)

Thanks!

Comment 4

[Julien Wajsberg [:julienw]]

Comment on attachment 8690751 [details] [review]
[gaia] julienw:1227068-fix-chunk-size > mozilla-b2g:master

I think it's ready for a review. There are test failures but I don't think it's related..

Comment 5

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8690751 [details] [review]
[gaia] julienw:1227068-fix-chunk-size > mozilla-b2g:master

r=me, just one optional nit at GitHub. I've tried PR on the Flame with heavy workload - looks much better with PR.

Thanks!

Comment 6

[Julien Wajsberg [:julienw]]

master: https://github.com/mozilla-b2g/gaia/commit/9d4faca327c1ea23758949d61d76bcdc4d21cb24

Comment 8

[Julien Wajsberg [:julienw]]

Comment on attachment 8690751 [details] [review]
[gaia] julienw:1227068-fix-chunk-size > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1091441
[User impact] if declined: Bad flickering and quite bad experience. Also fixed bug 1227068.
[Testing completed]: yes (integration and unit tests + manual)
[Risk to taking this patch] (and alternatives if risky): low, no logic has been changed, only some constants. Moreover one more test has been added.
[String changes made]: none

Comment 9

[Julien Wajsberg [:julienw]]

Hey Mahe, how come this approval request was not handled for 1 month ?
Thanks

Comment 10

[Mahendra Potharaju [:mahe]]

Comment on attachment 8690751 [details] [review]
[gaia] julienw:1227068-fix-chunk-size > mozilla-b2g:master

Hey Julien, Limiting 2.5 only to TV patches. Foxfooders getting updates from master/b2g-ota branch. So Removing the uplift nomination.

Thank you