1227106 - Add 'Open Last Tab' dynamic Quick Action to home screen

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Emily Toop (:fluffyemily)]

If the apps tab queue is not empty, add a 'Open Last Sent Tab' (wording to be confirmed) Quick Action to the quick actions menu, otherwise do not display

https://mozilla.invisionapp.com/share/SN5082W3J#/screens/116857630

Comment 1

[Emily Toop (:fluffyemily)]

Wording to be 'Open Last Tab'. Confirm with :tecgirl before implementing.

Comment 2

[Emily Toop (:fluffyemily)]

This is not really possible as originally invisioned as we can only display actions that are defined when the app last went into the background/was terminated. This means that tabs sent to the device from an extension cannot be added to the dynamic actions until _after_ the app has been opened.

:tecgirl - what we can do here is add the action when we open the sent tabs in the app, so that next time you hit quick actions you can see the last tab that was sent to you (similar to the bookmarks). Is this enough for a first pass while you rethink?

Comment 3

[Robin Andersen [:tecgirl]]

:fluffyemily - yes, that would be good enough for now. thank you!

Comment 4

[Emily Toop (:fluffyemily)]

Attachment: Pull request

Use the View Later or Send Tab action extensions to add an Open Last Tab quick action to the home screen menu.

Comment 5

[Stephan Leroux [:sleroux]]

Comment on attachment 8695896 [details] [review]
Pull request

Looks good - same comments as the other related PR. Also unable to test the force touch interaction.

Comment 6

[Robin Andersen [:tecgirl]]

Comment on attachment 8695896 [details] [review]
Pull request

I could not get this to work using View Later, but I did get it to work after using Send Tab. However, the URL isn't show below the title, see http://c.tecgirl.com/eA8x

Comment 7

[Emily Toop (:fluffyemily)]

(In reply to Robin Andersen [:tecgirl] from comment #6)
> Comment on attachment 8695896 [details] [review]
> Pull request
> 
> I could not get this to work using View Later, but I did get it to work
> after using Send Tab. However, the URL isn't show below the title, see
> http://c.tecgirl.com/eA8x

I'm raising these as a 2 separate issues:

View Later not setting Last Tab quick action: https://bugzilla.mozilla.org/show_bug.cgi?id=1236567
URL not showing below title of Last Tab quick action: https://bugzilla.mozilla.org/show_bug.cgi?id=1236565