Closed Bug 1227123 Opened 6 years ago Closed 6 years ago

Improve error message when rebase fails in an autoland push

Categories

(MozReview Graveyard :: General, defect)

Product:
MozReview Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dminor, Assigned: dminor)

Details

Attachments

(1 file)

MozReview Request: autoland: Improve error message when rebase fails in an autoland push (bug 1227123) r=mdoglio
40 bytes, text/x-review-board-request
mdoglio
: review+
Details 
At the moment, a failed rebase gives an hg error like:

hg error in cmd: hg rebase -d 1de17d1fb561: rebasing 3447:c65d1841a21b "autoland: report failed attempts to land due to tree closures to MozReview (Bug 1182585) r=smacleod" (tip) unresolved conflicts (see hg resolve, then hg rebase --continue)

We should detect this error, give it a nice header and provide instructions on what to do next.
autoland: Improve error message when rebase fails in an autoland push (bug 1227123) r=mdoglio

The only expected error for autoland is a rebase failing because it needs to
be done manually. This adds a nicer error message for this case.
Attachment #8690837 - Flags: review?(mdoglio)
Comment on attachment 8690837 [details]
MozReview Request: autoland: Improve error message when rebase fails in an autoland push (bug 1227123) r=mdoglio

https://reviewboard.mozilla.org/r/25973/#review23475
Attachment #8690837 - Flags: review?(mdoglio) → review+
Comment on attachment 8690837 [details]
MozReview Request: autoland: Improve error message when rebase fails in an autoland push (bug 1227123) r=mdoglio

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25973/diff/1-2/
Assignee: nobody → dminor
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.