1227193 - Attachment size displayed as {} bytes

Status: RESOLVED FIXED

Description

[John Whitlock [:jwhitlock]]

What did you do?
================
1. As logged-in user, go to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dl$edit
2. Scroll to Attachment list at bottom

What happened?
==============
The size of attachments is listed as "{} bytes"

What should have happened?
==========================
The size of the attachments should be displayed

Is there anything else we should know?
======================================
It is difficult to reproduce this on a developer box, because a 500 error is raised when reading the size of attachments that are not in the local box.

Comment 1

[John Whitlock [:jwhitlock]]

Created attachment 8690877 [details]
Screenshot of "{} bytes" display

Comment 2

[John Whitlock [:jwhitlock]]

Recorded 500 error in development as bug 1227197

Comment 3

[Rob Hudson [:robhudson]]

We have two localized strings:
* "%(bytes)s bytes" in kuma/attachments/templates/attachments/attachment_detail.html
* "%s bytes" in kuma/attachments/templates/attachments/includes/attachment_row.html

Whatever the fix is here we should also normalize on the former.

Comment 5

[Alex M]

I uploaded https://github.com/mozilla/kuma/pull/3803

Comment 6

[Alex M]

(no editbugs so I can't claim the bug)

Comment 7

[Jannis Leidel [:jezdez]]

This will be fixed in https://github.com/mozilla/kuma/pull/3769

Comment 8

[MDN Team (:mdn-dev)]

Commit pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/a24447c09d32380b08d0c19e2bd0d4dc617b93a8
Fix bug 1227193 - Render attachment size correctly.

Also normalized the translated string to one form.