1227205 - Verify Email button does nothing in Nightly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Sync, defect)

Description

[Ryan Feeley [:rfeeley]]

Attachment: Verify Email Animation

See attached animation. Should open new frame that lets user resend email.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Bugger - I deleted the string in bug 1205928 :(

Comment 2

[Mark Hammond [:markh] [:mhammond]]

(FTR, it works and causes the mail to be sent, it just doesn't update the UI)

Comment 3

[Mark Hammond [:markh] [:mhammond]]

(In reply to Mark Hammond [:markh] from comment #1)
> Bugger - I deleted the string in bug 1205928 :(

Flod, a couple of strings were deleted in 44 that are still in use. Can you offer advice on how to resolve this - can I reinstate those strings and ask for uplift, or must they ride the trains (and if so, can I use the same IDs?)

Comment 4

[Francesco Lodolo [:flod]]

Per discussion on IRC, there's no way to resurrect strings. You can add them back in mozilla-central, using the same IDs (they're the same strings), and let the change ride the trains.

One temporary patch would be to find an existing string in 44, but I can't find any suitable :-\
Stringless alternative: after the click, disable the button until a restart, to make sure people don't click it multiple times.

Do we have any idea from FHR how frequently that feature is used?

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0001-Bug-1227205-reinstate-strings-used-to-display-the-em.patch

(In reply to Francesco Lodolo [:flod] from comment #4)

> Stringless alternative: after the click, disable the button until a restart,
> to make sure people don't click it multiple times.

The cost of the user clicking multiple times is fairly low - the server implements throttling so they'll typically only get 2 messages regardless of how often they click. As mentioned, the button works, it just doesn't say that it worked.

> Do we have any idea from FHR how frequently that feature is used?

No :(

Anyway, this patch re-adds the strings and I guess we'll ponder if there is anything else we can do for the 6 weeks the strings will be missing on release.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c3c9f643350b

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c3c9f643350b