Verify Email button does nothing in Nightly

RESOLVED FIXED

Status

Firefox OS
Sync
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: rfeeley, Assigned: markh)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
Created attachment 8690897 [details]
Verify Email Animation

See attached animation. Should open new frame that lets user resend email.
(Assignee)

Comment 1

2 years ago
Bugger - I deleted the string in bug 1205928 :(
Assignee: nobody → markh
Blocks: 1205928
(Assignee)

Comment 2

2 years ago
(FTR, it works and causes the mail to be sent, it just doesn't update the UI)
(Assignee)

Comment 3

2 years ago
(In reply to Mark Hammond [:markh] from comment #1)
> Bugger - I deleted the string in bug 1205928 :(

Flod, a couple of strings were deleted in 44 that are still in use. Can you offer advice on how to resolve this - can I reinstate those strings and ask for uplift, or must they ride the trains (and if so, can I use the same IDs?)
Flags: needinfo?(francesco.lodolo)
Per discussion on IRC, there's no way to resurrect strings. You can add them back in mozilla-central, using the same IDs (they're the same strings), and let the change ride the trains.

One temporary patch would be to find an existing string in 44, but I can't find any suitable :-\
Stringless alternative: after the click, disable the button until a restart, to make sure people don't click it multiple times.

Do we have any idea from FHR how frequently that feature is used?
Flags: needinfo?(francesco.lodolo)
(Assignee)

Comment 5

2 years ago
Created attachment 8692780 [details] [diff] [review]
0001-Bug-1227205-reinstate-strings-used-to-display-the-em.patch

(In reply to Francesco Lodolo [:flod] from comment #4)

> Stringless alternative: after the click, disable the button until a restart,
> to make sure people don't click it multiple times.

The cost of the user clicking multiple times is fairly low - the server implements throttling so they'll typically only get 2 messages regardless of how often they click. As mentioned, the button works, it just doesn't say that it worked.

> Do we have any idea from FHR how frequently that feature is used?

No :(

Anyway, this patch re-adds the strings and I guess we'll ponder if there is anything else we can do for the 6 weeks the strings will be missing on release.
Attachment #8692780 - Flags: review?(adw)

Updated

2 years ago
Attachment #8692780 - Flags: review?(adw) → review+

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c3c9f643350b
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.