Tab counter set at 0 after restore from crash/hang

RESOLVED FIXED

Status

()

Firefox for iOS
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aaronmt, Assigned: bnicholson)

Tracking

(Depends on: 1 bug, {reproducible})

unspecified
All
iOS
reproducible

Firefox Tracking Flags

(fxios+)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Currently on browser restore, the tab counter is set at 0.

* Visit http://mana.mozilla.org (signed-out) in a new private tab
* Hang (bug 1224849)
* Swipe Firefox away from running applications
* Launch the browser again

See tab counter set to 0.
Flags: needinfo?(sleroux)
tracking-fxios: ? → 1.3+

Updated

2 years ago
Rank: 10
(Reporter)

Updated

2 years ago
Depends on: 1232704
(Reporter)

Comment 1

2 years ago
Forgot to change summary, this seems to happen after a hang or crash. I ran into it today again. I swiped Firefox away, re-opened and my counter was 0.
Summary: Tab counter set at 0 after restore → Tab counter set at 0 after restore from crash/hang
Rank: 10 → 2
tracking-fxios: 1.3+ → +
(Assignee)

Comment 2

2 years ago
I'll have a look.
Assignee: nobody → bnicholson
Status: NEW → ASSIGNED
Flags: needinfo?(sleroux)
(Assignee)

Comment 3

2 years ago
Created attachment 8711923 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1475
Attachment #8711923 - Flags: review?(sleroux)
Comment on attachment 8711923 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1475

I was able to verify the fix by producing a real crash. Looks good!
Attachment #8711923 - Flags: review?(sleroux) → review+
(Assignee)

Comment 5

2 years ago
https://github.com/mozilla/firefox-ios/commit/818d4027993758b166ed3fab37cf2f913a18d358
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED

Comment 6

2 years ago
This issue is still reproducible in build 2.0 (4).
(Reporter)

Comment 7

2 years ago
Is the commit in the build?
Flags: needinfo?(bnicholson)
(Assignee)

Comment 8

2 years ago
Don't think it made the last build -- please check again on the next update.
Flags: needinfo?(bnicholson)
You need to log in before you can comment on or make changes to this bug.