1227215 - Tab counter set at 0 after restore from crash/hang

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Aaron Train [:aaronmt]]

Currently on browser restore, the tab counter is set at 0.

* Visit http://mana.mozilla.org (signed-out) in a new private tab
* Hang (bug 1224849)
* Swipe Firefox away from running applications
* Launch the browser again

See tab counter set to 0.

Comment 1

[Aaron Train [:aaronmt]]

Forgot to change summary, this seems to happen after a hang or crash. I ran into it today again. I swiped Firefox away, re-opened and my counter was 0.

Comment 2

[Brian Nicholson (:bnicholson)]

I'll have a look.

Comment 3

[Brian Nicholson (:bnicholson)]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1475

Comment 4

[Stephan Leroux [:sleroux]]

Comment on attachment 8711923 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1475

I was able to verify the fix by producing a real crash. Looks good!

Comment 5

[Brian Nicholson (:bnicholson)]

https://github.com/mozilla/firefox-ios/commit/818d4027993758b166ed3fab37cf2f913a18d358

Comment 6

[Flaviu Cos]

This issue is still reproducible in build 2.0 (4).

Comment 7

[Aaron Train [:aaronmt]]

Is the commit in the build?

Comment 8

[Brian Nicholson (:bnicholson)]

Don't think it made the last build -- please check again on the next update.