Closed Bug 1227239 Opened 9 years ago Closed 9 years ago

Talos should not generate summary results for suites with only one test

Categories

(Testing :: Talos, defect)

Product:
Testing
Component:
Talos
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox45 fixed, b2g-v2.5 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: wlach, Assigned: wlach)

References

Details

Attachments

(1 file, 1 obsolete file)

Fixed patch
1.27 KB, text/plain
jmaher
: review+
Details 
In bug 1162522 we fixed this on the perfherder side, then that got reversed when we switched to PERFHERDER_DATA. Really, this is talos' responsibility, so let's do the fix there.

        Attachment #8690945 -
        Flags: review?(jmaher)

    
    

    
  
Comment on attachment 8690945 [details] [diff] [review]
Don't summarize talos suites with only one test

Review of attachment 8690945 [details] [diff] [review]:
-----------------------------------------------------------------

is there a concern in perfherder about catching a missing suite['value']?  If not, this looks great.

        Attachment #8690945 -
        Flags: review?(jmaher) → review+

    
    

    
  
(In reply to Joel Maher (:jmaher) from comment #3)
> is there a concern in perfherder about catching a missing suite['value']? 
> If not, this looks great.

Nope, counters for example are already submitted with no suite summary value, and work fine.

    
    

    
  

      
      
      
      

        Attached file
          
        Fixed patch
        — 
      

    


  
I believe this should actually work.

        Attachment #8690945 -
        Attachment is obsolete: true

        Attachment #8691441 -
        Flags: review?(jmaher)

    
    

    
  
Comment on attachment 8691441 [details]
Fixed patch

oh, yeah

        Attachment #8691441 -
        Flags: review?(jmaher) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/77cd4c03f303
Status: NEW → RESOLVED
Closed: 9 years ago

          status-firefox45:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: