1227271 - crash in nsScriptSecurityManager::InitStatics

Status: RESOLVED INCOMPLETE

(Core :: Security: CAPS, defect)

Description

[Liz Henry (:lizzard) (relman/hg->git project)]

This bug was filed from the Socorro interface and is 
report bp-7fec7560-2d7f-4fb0-94b0-f10162151121.
=============================================================

Startup crash, appears in 40 and onwards, but in 43 beta 5 this crash signature seems to be on the rise. 


Crashing thread:

0 	xul.dll 	nsScriptSecurityManager::InitStatics() 	caps/nsScriptSecurityManager.cpp
1 		@0x4ee61b 	
2 	xul.dll 	nsCOMPtr<nsIScriptError>::nsCOMPtr<nsIScriptError>(nsCOMPtr_helper const&) 	xpcom/glue/nsCOMPtr.h
3 	xul.dll 	nsChromeRegistry::LogMessageWithContext(nsIURI*, unsigned int, unsigned int, char const*, ...) 	chrome/nsChromeRegistry.cpp
4 	xul.dll 	nsChromeRegistryChrome::ManifestLocale(nsChromeRegistry::ManifestProcessingContext&, int, char* const*, int) 	chrome/nsChromeRegistryChrome.cpp
5 	xul.dll 	ParseManifest(NSLocationType, mozilla::FileLocation&, char*, bool, bool) 	xpcom/components/ManifestParser.cpp
6 	xul.dll 	DoRegisterManifest 	xpcom/components/nsComponentManager.cpp
7 	xul.dll 	nsComponentManagerImpl::ManifestManifest(nsComponentManagerImpl::ManifestProcessingContext&, int, char* const*) 	xpcom/components/nsComponentManager.cpp
8 	mozglue.dll 	mozglue.dll@0x28af 	
9 	xul.dll 	DoRegisterManifest 	xpcom/components/nsComponentManager.cpp

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Wontfix for 43. This signature is still showing up in 43.0b8. 

Daniel, Bobby, you seem like likely people to investigate this at some point. n-i just to make sure you see it.

Comment 2

[Bobby Holley (:bholley)]

We're crashing here: http://hg.mozilla.org/releases/mozilla-beta/annotate/68a94164ec0c/caps/nsScriptSecurityManager.cpp#l1364

nsScriptSecurityManager::Init can fail in one of the following three places:
* http://hg.mozilla.org/releases/mozilla-beta/annotate/68a94164ec0c/caps/nsScriptSecurityManager.cpp#l1289
* http://hg.mozilla.org/releases/mozilla-beta/annotate/68a94164ec0c/caps/nsScriptSecurityManager.cpp#l1296
* http://hg.mozilla.org/releases/mozilla-beta/annotate/68a94164ec0c/caps/nsScriptSecurityManager.cpp#l1299

All of those are pretty generic XPCOM-y things (getting the io service, and getting the string bundle), and none have been obviously touched recently.

If we want to investigate this, the next step would be to narrow it down between those failure sites (with a MOZ_CRASH at each, since we'll MOZ_CRASH anyway), and then figure out what's going on.

I don't have the cycles to do it. Over to Benjamin to prioritize and find an owner if needed.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Thanks Bobby. This isn't a very high volume crash. A few crash reports are now showing up in 45, so I'm marking it as affected.

Comment 4

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked for 44 as it's a crash.

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

The crash rate on this one in Beta44 is going down as follows:

Firefox 	44.0b1 	16.07% 	63
Firefox 	44.0b2 	3.32% 	13
Firefox 	44.0b4 	1.53% 	6

Comment 6

[Benjamin Smedberg]

CreateBundle for chrome://global/locale/security/caps.properties is the most likely problem here. We've had similar issues with corrupt omni.ja. We don't know what's happening there.

I don't think this is actionable as filed and recommend resolving INCOMPLETE.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Closing it (cf comment #6).