1227308 - Add metadata for tresize in Talos logs

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

["Saptarshi Guha[:joy]"]

Consider 

http://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-central-win64/1447967412/mozilla-central_win8_64_test-chromez-bm112-tests1-windows-build31.txt.gz

(see line number 1804)


This contains results data for tcvansmark and tresize in the Perfherde format (see Bug 1222588)
Though the tcanvasmark tests contain the 'unit' field, tresize doesn't.

I suggest we add the 'unit' field for all tests (which will get reflected in the PerfHerder entry).

Saptarshi

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

would you prefer this rather than assuming a default unit of 'time' ?  We could easily add the default into there.

Comment 2

[William Lachance (:wlach)]

"time" won't always be valid when adding new tests, so I'd prefer not to make it a default. Let's leave it blank in those cases so we'll know to fix it.

For now, let's just fix all the talos tests that still don't have units assigned.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: explicit add of unit for each test

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: and the right patch this time

Comment 5

[Julien Pagès (:parkouss)]

Comment on attachment 8698004 [details] [diff] [review]
and the right patch this time

media_tests do not have any unit and is is the only one. Also, shouldn't we add lower_is_better = False where it make sense, e.g for all scores units ?

I don't know what should be the units for every test. Most of them looks good, according to the comments.

So r+, just be sure to update media_tests unit if it should - and to add lower_is_better = False if required to the score units.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3111b6b59755

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3111b6b59755