|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
Created attachment 8691066 [details] general -> home See the attached screenshots. I imagine the items should be aligned.
Created attachment 8691068 [details] search Anthony, what do you think? Should these items just fall into the standard alignment of the other items?
3 years ago
Whiteboard: [lang=java][good next bug]
(In reply to Michael Comella (:mcomella) from comment #0) > Created attachment 8691066 [details] > general -> home > > See the attached screenshots. I imagine the items should be aligned. I'm not sure why "General | Home" is here... But yes, the Panel names should be aligned. E.g. "Top Sites, Bookmarks, History, etc". (In reply to Michael Comella (:mcomella) from comment #1) > Created attachment 8691068 [details] > search > > Anthony, what do you think? Should these items just fall into the standard > alignment of the other items? Yep! As above, everything should probably left-align with the "Search" text that's on the top.
Take a look into preferences_home & PanelsPreferenceCategory – we write a custom preference that appears to add it's own layouts which are probably missing the appropriate padding.
I began work on the task.
Created attachment 8736406 [details] MozReview Request: Bug 1227321 - Padding fix, r=mcomella Use title padding. r=mcomella Review commit: https://reviewboard.mozilla.org/r/43271/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43271/
Comment on attachment 8736406 [details] MozReview Request: Bug 1227321 - Padding fix, r=mcomella Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43271/diff/1-2/
2 years ago
Attachment #8736406 - Flags: review?(michael.l.comella) → review+
Comment on attachment 8736406 [details] MozReview Request: Bug 1227321 - Padding fix, r=mcomella https://reviewboard.mozilla.org/r/43271/#review39907 Nice! This is a really elegant solution! One comment: we'll make the correction on our side this time but in the future, can you make your patch comment more descriptive? For example, for this bug, "Corrected padding on "Panels" item in preferences." I made a push to our try test servers on the review page. Once the push goes green, you can add the "checkin-needed" keyword  to get your patch checked in. Note that all patches added via checkin-needed keyword need an associated green try run. Let me know if you need help reading the results. : https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree
2 years ago
Assignee: nobody → litunone
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.