Settings indentation on tablets is funky

RESOLVED FIXED in Firefox 48

Status

()

Firefox for Android
General
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: mcomella, Assigned: litunone, Mentored)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 48
All
Android
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

(Whiteboard: [lang=java][good next bug])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

Created attachment 8691066 [details]
general -> home

See the attached screenshots. I imagine the items should be aligned.
Created attachment 8691068 [details]
search

Anthony, what do you think? Should these items just fall into the standard alignment of the other items?
Flags: needinfo?(alam)
Whiteboard: [lang=java][good next bug]
(In reply to Michael Comella (:mcomella) from comment #0)
> Created attachment 8691066 [details]
> general -> home
> 
> See the attached screenshots. I imagine the items should be aligned.

I'm not sure why "General | Home" is here... But yes, the Panel names should be aligned. E.g. "Top Sites, Bookmarks, History, etc".

(In reply to Michael Comella (:mcomella) from comment #1)
> Created attachment 8691068 [details]
> search
> 
> Anthony, what do you think? Should these items just fall into the standard
> alignment of the other items?

Yep! As above, everything should probably left-align with the "Search" text that's on the top.
Flags: needinfo?(alam)
Take a look into preferences_home & PanelsPreferenceCategory – we write a custom preference that appears to add it's own layouts which are probably missing the appropriate padding.
(Assignee)

Comment 4

2 years ago
I began work on the task.
(Assignee)

Comment 5

2 years ago
Created attachment 8736406 [details]
MozReview Request: Bug 1227321 - Padding fix, r=mcomella

Use title padding.
r=mcomella

Review commit: https://reviewboard.mozilla.org/r/43271/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43271/
(Assignee)

Comment 6

2 years ago
Comment on attachment 8736406 [details]
MozReview Request: Bug 1227321 - Padding fix, r=mcomella

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43271/diff/1-2/
Attachment #8736406 - Attachment description: MozReview Request: Bug 1227321 - → MozReview Request: Bug 1227321 - Padding fix, r=mcomella
Attachment #8736406 - Flags: review?(michael.l.comella)
Attachment #8736406 - Flags: review?(michael.l.comella) → review+
Comment on attachment 8736406 [details]
MozReview Request: Bug 1227321 - Padding fix, r=mcomella

https://reviewboard.mozilla.org/r/43271/#review39907

Nice! This is a really elegant solution!

One comment: we'll make the correction on our side this time but in the future, can you make your patch comment more descriptive? For example, for this bug, "Corrected padding on "Panels" item in preferences."

I made a push to our try test servers on the review page.

Once the push goes green, you can add the "checkin-needed" keyword [1] to get your patch checked in. Note that all patches added via checkin-needed keyword need an associated green try run. Let me know if you need help reading the results.

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree
Assignee: nobody → litunone
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5ea59d4c9ea5
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.