Closed Bug 1227393 Opened 9 years ago Closed 9 years ago

MediaFormatReader recalculating buffered range more than necessary

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox45 --- affected

People

(Reporter: jya, Assigned: jya)

References

Details

The algorithm was appropriate when MediaDecoderReader::GetBuffered() was called on the main thread.

We had to ensure that we only queried the demuxer on the reader's task queue and didn't have to recalculate every single time GetBuffered() was called.

We really only need to query the buffered range when we actually need it, without the need to cache the content prior needing it.
Assignee: nobody → jyavenard
Turned out that this may not be that necessary, because as soon as MediaDecoderReader::NotifyDataArrived() is called; it immediately calls MediaDecoderReader::GetBuffered()

as such, calculating the buffered range as soon as NotifyDataArrived() is called doesn't have a negative impact.
There's nothing to improve here, not the way NotifyDataArrived() followed by GetBuffered() is called
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.