Closed
Bug 1227415
Opened 8 years ago
Closed 8 years ago
Decoded video size becomes a bit smaller during seeking video on nexus-5-l and aries
Categories
(Core :: Audio/Video: Playback, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
(Whiteboard: [backout-asap])
Attachments
(1 file)
2.52 KB,
patch
|
jhlin
:
review+
|
Details | Diff | Splinter Review |
Decoded video size becomes a bit smaller during seeking the following video on nexus-5-l. http://people.mozilla.org/~cpeterson/videos/H264_Baseline_Profile_Level_30_640x360p.mp4
Assignee | ||
Comment 1•8 years ago
|
||
It seems regression of bug 1199809.
Assignee: nobody → sotaro.ikeda.g
Blocks: 1199809
Updated•8 years ago
|
Priority: -- → P2
Hardware: Unspecified → ARM
Assignee | ||
Comment 2•8 years ago
|
||
When the problem happens, there are difference between encoded video size and display video size. H264_Baseline_Profile_Level_30_640x360p.mp4: display size(640, 360), encoded size(640, 368).
Assignee | ||
Comment 3•8 years ago
|
||
The problem happen also on flame-kk and aries(kk).
Summary: Decoded video size becomes a bit smaller during seeking video on nexus-5-l → Decoded video size becomes a bit smaller during seeking video on gonk
Assignee | ||
Comment 4•8 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #3) > The problem happen also on flame-kk and aries(kk). Sorry, the problem does not happen on flame-kk. The problem happens on nexus-5-l and aries.
Assignee | ||
Updated•8 years ago
|
Summary: Decoded video size becomes a bit smaller during seeking video on gonk → Decoded video size becomes a bit smaller during seeking video on nexus-5-l and aries
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #2) > When the problem happens, there are difference between encoded video size > and display video size. > > H264_Baseline_Profile_Level_30_640x360p.mp4: display size(640, 360), decoded size(640, 368). On flame-kk, display size(640, 360) and decoded size(640, 360). Both are equal size and there is not problem of crop rect.
Assignee | ||
Comment 6•8 years ago
|
||
The patch fixed the video rendering size during seeking. But there is still video size difference. The remaining problem seems to be caused by EGL_ANDROID_image_crop. Crop setting in EGLImageCreateFromNativeBuffer() seems not work correctly. It might be a POVD problem.
Assignee | ||
Comment 7•8 years ago
|
||
EGLImageCreateFromNativeBuffer() https://dxr.mozilla.org/mozilla-central/source/gfx/layers/opengl/EGLImageHelpers.cpp#18
Assignee | ||
Updated•8 years ago
|
Attachment #8691306 -
Flags: review?(jolin)
Comment 8•8 years ago
|
||
Comment on attachment 8691306 [details] [diff] [review] patch - Fix copy buffer size Review of attachment 8691306 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. And thanks for removing the unused parameter! :)
Attachment #8691306 -
Flags: review?(jolin) → review+
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e1372ddbf94d
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Comment 11•8 years ago
|
||
This landing for this issue has caused the smoketest blocking bug 1230258.
Whiteboard: [backout-asap]
You need to log in
before you can comment on or make changes to this bug.
Description
•