1227415 - Decoded video size becomes a bit smaller during seeking video on nexus-5-l and aries

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Sotaro Ikeda [:sotaro]]

Decoded video size becomes a bit smaller during seeking the following video on nexus-5-l.
  http://people.mozilla.org/~cpeterson/videos/H264_Baseline_Profile_Level_30_640x360p.mp4

Comment 1

[Sotaro Ikeda [:sotaro]]

It seems regression of bug 1199809.

Comment 2

[Sotaro Ikeda [:sotaro]]

When the problem happens, there are difference between encoded video size and display video size.

H264_Baseline_Profile_Level_30_640x360p.mp4: display size(640, 360), encoded size(640, 368).

Comment 3

[Sotaro Ikeda [:sotaro]]

The problem happen also on flame-kk and aries(kk).

Comment 4

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #3)
> The problem happen also on flame-kk and aries(kk).

Sorry, the problem does not happen on flame-kk.

The problem happens on nexus-5-l and aries.

Comment 5

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #2)
> When the problem happens, there are difference between encoded video size
> and display video size.
> 
> H264_Baseline_Profile_Level_30_640x360p.mp4: display size(640, 360), decoded size(640, 368).

On flame-kk, display size(640, 360) and decoded size(640, 360). Both are equal size and there is not problem of crop rect.

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix copy buffer size

The patch fixed the video rendering size during seeking. But there is still video size difference. The remaining problem seems to be caused by EGL_ANDROID_image_crop. Crop setting in EGLImageCreateFromNativeBuffer() seems not work correctly. It might be a POVD problem.

Comment 7

[Sotaro Ikeda [:sotaro]]

EGLImageCreateFromNativeBuffer()
 https://dxr.mozilla.org/mozilla-central/source/gfx/layers/opengl/EGLImageHelpers.cpp#18

Comment 8

[John Lin [:jhlin][:jolin]]

Comment on attachment 8691306 [details] [diff] [review]
patch - Fix copy buffer size

Review of attachment 8691306 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. And thanks for removing the unused parameter! :)

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1372ddbf94d

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e1372ddbf94d

Comment 11

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This landing for this issue has caused the smoketest blocking bug 1230258.