Closed
Bug 122744
Opened 23 years ago
Closed 23 years ago
Charting fails taint checks
Categories
(Bugzilla :: Reporting/Charting, defect, P1)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.16
People
(Reporter: bbaetz, Assigned: bbaetz)
Details
Attachments
(1 file)
|
1.48 KB,
patch
|
gerv
:
review+
gerv
:
review+
|
Details | Diff | Splinter Review |
Try to do a chart, and you'll get a taint error. Their are two problems:
First, we weren't detainting the product name after checking it. Secondly, the
name of the file depend son input from the fields. For several reasons (see
comments in the patch) we can't only allow valid inputs, so just do basic
"letter+number" checks.
|
Assignee | |
Comment 1•23 years ago
|
||
daa reported this; forgot to cc him
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → Bugzilla 2.16
|
|
Assignee | |
Comment 2•23 years ago
|
||
|
||
Comment 3•23 years ago
|
||
|
||
Comment 4•23 years ago
|
||
Comment on attachment 67229 [details] [diff] [review]
patch
r=gerv.
Gerv
Attachment #67229 -
Flags: review+
|
|
Assignee | |
Comment 5•23 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•