Closed Bug 122744 Opened 21 years ago Closed 21 years ago

Charting fails taint checks

Categories

(Bugzilla :: Reporting/Charting, defect, P1)

2.15
x86
Linux
defect

Tracking

()

RESOLVED FIXED
Bugzilla 2.16

People

(Reporter: bbaetz, Assigned: bbaetz)

Details

Attachments

(1 file)

Try to do a chart, and you'll get a taint error. Their are two problems:

First, we weren't detainting the product name after checking it. Secondly, the
name of the file depend son input from the fields. For several reasons (see
comments in the patch) we can't only allow valid inputs, so just do basic
"letter+number" checks.
daa reported this; forgot to cc him
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → Bugzilla 2.16
Attached patch patchSplinter Review
Comment on attachment 67229 [details] [diff] [review]
patch

r=gerv.

Gerv
Attachment #67229 - Flags: review+
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.