1227474 - Promisify all client methods

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Alexandre Poirot [:ochameau]]

This is very frustrating when using Client APIs today as some returns promises and some others don't.
The very manual `DebuggerClient.request()` is going to return a promise,
whereas all the Client objects defined in devtools/shared/client/main.js that uses `requester` won't!
And all other client using protocol.js fronts are also returning promises.

Because of this, we end up creating inline promises everywhere we have to call a requester method while using Task.jsm.
Like:
  http://mxr.mozilla.org/mozilla-central/source/devtools/client/framework/connect/connect.js#93

And it is all related to requester not returning the call the DebuggerClient.request.
At first, I thought changing this to return the promise would break many tests, but it looks like, it doesn't:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5c6dbf9aa1d

I would like to land this, spread the word about this and may be try to remove a bunch of these inlined promises that kill the readability of our codebase in various places.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: patch v1

Comment 2

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=efff60afef52

Comment 3

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e082fe0d914

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8691333 [details] [diff] [review]
patch v1

Review of attachment 8691333 [details] [diff] [review]:
-----------------------------------------------------------------

Hmm, seems too simple. :P

Please at least file a bug to clean up the inline usages.

What about the top-level methods in `DebuggerClient.prototype`?  Many of those don't use `requester`, but would still benefit from promises.

Comment 5

[Alexandre Poirot [:ochameau]]

Yes, I started cleanup up the codebase to benefit from new requester behavior
and hit DebuggerClient.connect/close not being promise ready.

Comment 6

[Alexandre Poirot [:ochameau]]

https://hg.mozilla.org/integration/fx-team/rev/1f527cd0e45af932a8b825ee1e24e74c7c85324a
Bug 1227474 - Promisify all client methods. r=jryans

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1f527cd0e45a