1227639 - Worker debugger error reporting misses some cases

Status: RESOLVED INACTIVE

(DevTools :: Debugger, defect)

Description

[Boris Zbarsky [:bzbarsky]]

We should probably do the ReportErrorToDebugger thing even if !aFireAtScope and !aTarget.  Not sure what should happen if !aWorkerPrivate, but probably then too.

Otherwise seems like we'll fire onerror handlers on parents in some cases instead of ReportErrorToDebugger.

Probably enough to just get CurrentGlobalOrNull(aCx) and if not null and not a WorkerGlobalScope immediately take the debugger codepath, I think.

Comment 1

[Jason Laster [:jlast]]

Brian, is this still relevant?

Comment 2

[Brian Hackett [Laid off!]]

I think so? This is referring to WorkerErrorReport::ReportError I think which only calls ReportErrorToDebugger under certain circumstances. I don't understand these tests or the variables they are operating on, though, so without STR I don't know what needs to change here.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

There is no activity for a long time and there are also no STRs, closing.

Honza