1227656 - Clicking on a search result containing add-ons returns a 404

Status: RESOLVED WORKSFORME

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Launch marketplace-dev app on your 2.5 device
2. Switch to the add-ons tab
3. Search for M in status bar
4. Click the add-on in the search results


expected behavior:
add-on detail page loads

actual behavior:
add-on details page returns a 404 since we are loading https://marketplace-dev.allizom.org/api/v2/fireplace/app/m-in-status-bar/?cache=1&dev=firefoxos&lang=en-US&limit=10&pro=%3D%2F%2F%2F%2F%2F%2F%2F%2FLw%3D%3D.54.9&region=us&vary=0

basically trying to find an app when the user is looking for an add-on

Comment 1

[Mathieu Pillard [:mat]]

Not just a model caching issue (through that's part of it, see appOrWebsite() https://github.com/mozilla/fireplace/blob/master/src/media/js/helpers_local.js#L159 ) : all templates for search, product list, call app_tile(). Despite the name, that macro knows how to handle websites, but I don't think it knows how to handle add-ons correctly - there is a separate macro for add-ons.

Comment 2

[Mathieu Pillard [:mat]]

Revised STR:
You don't need to switch the the add-ons tab, you just need to search for something that will return add-ons. The add-on listing page is ok, it's the search page that's wrong when add-ons are shown in it.

Comment 3

[David Durst [:ddurst]]

According to mat, this is a fireplace issue.

Comment 4

[Davor Spasovski [:spasovski]]

Can't seem to repro this anymore please reopen if still an issue.