Remove update Ubuntu update prompt

RESOLVED FIXED

Status

Taskcluster
Docker Images
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: armenzg, Assigned: armenzg)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

When connected to VNC we saw the update prompt show up.
I assume that takes focus away.
Assignee: nobody → armenzg
I did not get better results.
I will have to see if it actually disables the prompt rather than assume.
Hi dustin, jmaher,
I wanted to see the tests working; I can't see them running when I connect to VNC.

docker run -ti --device=/dev/video1:/dev/video1 armenzg/desktop-test:0.5.0
apt-get install x11vnc
export DISPLAY=:0
Xvfb :0 -nolisten tcp -screen 0 1600x1200x24 &
gnome-session &
x11vnc &
cd ~worker
mkdir workspace && cd workspace
chown -R worker:worker /home/worker
curl --fail -o mozharness.zip --retry 10 -L https://queue.taskcluster.net/v1/task/LceXM3qyQia_sa6ISrs1xw/artifacts/public/build/mozharness.zip
unzip mozharness.zip
sudo -E -u worker python2.7 /home/worker/workspace/mozharness/scripts/desktop_unittest.py --config-file mozharness/configs/unittests/linux_unittest.py --config-file mozharness/configs/remove_executables.py --no-read-buildbot-config --installer-url=https://queue.taskcluster.net/v1/task/LceXM3qyQia_sa6ISrs1xw/artifacts/public/build/target.tar.bz2 --test-packages-url=https://queue.taskcluster.net/v1/task/LceXM3qyQia_sa6ISrs1xw/artifacts/public/build/test_packages.json --download-symbols=ondemand --reftest-suite=reftest --total-chunk=8 --this-chunk=1 --no-run-tests
# Separating into --no-run-tests to --run-tests allows me to *only* run the tests when I want
sudo -E -u worker python2.7 /home/worker/workspace/mozharness/scripts/desktop_unittest.py --config-file mozharness/configs/unittests/linux_unittest.py --config-file mozharness/configs/remove_executables.py --no-read-buildbot-config --installer-url=https://queue.taskcluster.net/v1/task/LceXM3qyQia_sa6ISrs1xw/artifacts/public/build/target.tar.bz2 --test-packages-url=https://queue.taskcluster.net/v1/task/LceXM3qyQia_sa6ISrs1xw/artifacts/public/build/test_packages.json --download-symbols=ondemand --reftest-suite=reftest --total-chunk=8 --this-chunk=1 --run-tests --binary-path /home/worker/workspace/build/application/firefox/firefox-bin
In fact, when I connect I can't interact with it.
what do you mean by interact?  is a firefox browser displayed and you cannot type in it or move the window around?
Let's ignore Firefox.

If I start x11vnc and I connect, I can see the mouse move, however, if I try to click on any of the icons of the desktop session nothing happens.

STR:
docker run -ti --device=/dev/video1:/dev/video1 armenzg/desktop-test:0.5.0
apt-get install x11vnc -y
export DISPLAY=:0
Xvfb :0 -nolisten tcp -screen 0 1600x1200x24 &
gnome-session &
x11vnc &
ifconfig | grep "172" (to find IP)
connect to it with a VNC client
try to click on something
--> expectation: the app opens
--> actual results: nothing opens
I recall that, but I could interact with firefox
dustin: could you please point me to the code changes for your image?
I can VNC to that one without any trouble.

In general, I'm finding trouble going from what run on TC to start up an environment similar to what was run plus run the exact command without exiting the image.

I find it a bit unfortunate that we can't start the environment properly without running Mozharness and exiting.

I wish the Window manager would get set up as part of connecting to the container rather that as part of the path to executing Mozharness.
this does indicate that our environment isn't fully ready- not sure if it is a blocker, but if we question it now, then others will question it in the future.
I think it might be a matter of timing on when I start vnc. gnome-session might not be fully loaded.
I think we could install vnc to the image and use START_VNC as a way to start it.

What do you think?
I have no idea- it seems like a worthwhile try.  Maybe :dustin or others would have some better insight.
I don't understand this bug.

What is "your image" in comment 8?  Any image I've published has been based on in-tree code, so it shouldn't be hard to find.

I don't understand the rest of comment 8, either.  If we set up the window manager as part of connecting to the container, then we won't have a window manager for the test runs (unless someone happens to connect to the container between the task starting and the test run starting, but with a test running every few seconds that would take an army of people with VNC clients).

It sounds like you'd like to connect and interact with a container without getting booted out when the task run completes, and maybe even without running the tests.  That should be a pretty easy modification to push to try -- just replace the mozharness invocation with `while true; do sleep 10; done`, or include that after the mozharness invocation.  So I suspect I'm not understanding what you're trying to do.

I'm also not sure why you're running vnc within the container, particularly without any options -- that may disable interaction, and anyway has a poor color resolution if I remember correctly.  The --interactive functionality of the docker worker is probably a better approach.
I just realized that you attach the code you based it on:
https://bugzilla.mozilla.org/show_bug.cgi?id=1223123#c25

It seems you start vnc before starting gnome-session (I do the opposite).

(In reply to Dustin J. Mitchell [:dustin] from comment #12)
> It sounds like you'd like to connect and interact with a container without
> getting booted out when the task run completes, and maybe even without
> running the tests.  That should be a pretty easy modification to push to try
> -- just replace the mozharness invocation with `while true; do sleep 10;
> done`, or include that after the mozharness invocation.  So I suspect I'm
> not understanding what you're trying to do.
> 
Yes, this should work.
I want to see the tests run and not be booted out.
The official image does not have VNC installed so I would try to access an interactive session and do what test-linux.sh to set the image up before running the tests.
Created attachment 8698053 [details]
MozReview Request: Bug 1227657 - Disable Ubuntu update prompt

Bug 1227657 - Disable Ubuntu update prompt
Comment on attachment 8698053 [details]
MozReview Request: Bug 1227657 - Disable Ubuntu update prompt

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27787/diff/1-2/
Attachment #8698053 - Flags: review?(dustin)
From what I read online, this should work.
I have not yet managed to start VNC properly to see if it works, however, I want to carry one less patch in my queue and come back to it if it doesn't work as expected.
Attachment #8698053 - Flags: review?(dustin) → review+
I pushed the image here as 0.5.0 (since that is where my version was standing at):
https://hub.docker.com/r/armenzg/desktop-test/tags/

Comment 20

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/55d6bbc66a2d
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.