Use template aliases for scoped pointers instead of macros in gtests

RESOLVED INVALID

Status

NSS
Libraries
RESOLVED INVALID
2 years ago
2 years ago

People

(Reporter: ttaubert, Unassigned)

Tracking

Firefox Tracking Flags

(firefox45 affected)

Details

(Reporter)

Description

2 years ago
Had to revert this in bug 1215295 after landing but it looks like we require C++11 now in external_tests/
You will note that the failed build didn't fail due to a lack of the necessary option, it failed because of the inconsistent implementation of this particular C++11 feature.

https://circleci.com/gh/nss-dev/nss/176

Note the command line includes the -std=c++0x option.

Macros are gross, but in this case I think that we should just suck it and get the better compatibility they provide.
(Reporter)

Comment 2

2 years ago
Ah, thanks for explaining, didn't have that link anymore. Let's stick with macros then.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.