Closed
Bug 1227686
Opened 9 years ago
Closed 8 years ago
Pull to sync row shows content behind it
Categories
(Firefox for iOS :: Home screen, defect)
Tracking
()
RESOLVED
INVALID
Tracking | Status | |
---|---|---|
fxios | + | --- |
People
(Reporter: dhenein, Assigned: bmunar, Mentored)
References
Details
(Whiteboard: [good first bug])
Attachments
(3 files)
122.20 KB,
image/png
|
Details | |
48 bytes,
text/x-github-pull-request
|
dhenein
:
ui-review-
|
Details | Review |
1.27 MB,
video/quicktime
|
Details |
As seen in History, likely visible in other panels as well.
That view should have a solid background or we should clip the underlying table view.
Reporter | ||
Comment 1•9 years ago
|
||
Updated•9 years ago
|
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → bmunar
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
LOL hello again
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8704251 -
Flags: ui-review?(dhenein)
Assignee | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•9 years ago
|
||
oops, wrong bug i closed hehe
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 5•9 years ago
|
||
Comment on attachment 8704251 [details] [review]
PR - tryna get Darrin's approval first
Not exactly what I had in mind, I dont think it should come in front of the table view. See Mail.app and the refresh behavior it has... refresh view should come from behind the table, and disappear behind it (and in fact, collapse) when the user scrolls back up.
Attachment #8704251 -
Flags: ui-review?(dhenein) → ui-review-
Comment 7•8 years ago
|
||
I'm guessing this was already fixed on another bug/task? From what I see the UI looks fairly different from the reported screenshot.
Also, I see the comment on GitHub: (https://github.com/mozilla-mobile/firefox-ios/pull/1401)
"@bkmunar I believe this has been resolved as part of the panel clean up work you did. Is that correct? If so, feel free to close this."
It looks to me that we can close this ticket and GitHub PR as well.
Comment 8•8 years ago
|
||
Comment 9•8 years ago
|
||
> I'm guessing this was already fixed on another bug/task? From what I see the UI looks fairly different from the reported screenshot.
This bug was for a section that now lives under the 'Synced Tabs' button instead of being a top level panel. I'm pretty sure this issue is no longer valid. Thanks for checking in and closing the PR!
Status: REOPENED → RESOLVED
Closed: 9 years ago → 8 years ago
Resolution: --- → INVALID
Comment 10•8 years ago
|
||
Stephan, the Github PR is still open ( https://github.com/mozilla-mobile/firefox-ios/pull/1401 ) I can't close it :)
Comment 11•8 years ago
|
||
My apologies - I've gone ahead and closed it.
You need to log in
before you can comment on or make changes to this bug.
Description
•