1227708 - Differentiate ICE_SUCCESS_RATE telemetry for loop vs webrtc

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P1)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Histograms already exist: "WEBRTC_ICE_SUCCESS_RATE" and "LOOP_ICE_SUCCESS_RATE".

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: MozReview Request: Bug 1227708 - Differentiate ICE_SUCCESS_RATE telemetry for loop vs webrtc

Bug 1227708 - Differentiate ICE_SUCCESS_RATE telemetry for loop vs webrtc

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8691548 [details]
MozReview Request: Bug 1227708 - Differentiate ICE_SUCCESS_RATE telemetry for loop vs webrtc

https://reviewboard.mozilla.org/r/26135/#review23931

::: dom/media/PeerConnection.js:1328
(Diff revision 1)
> -    var histogram = Services.telemetry.getHistogramById("WEBRTC_ICE_SUCCESS_RATE");
> +    var id = this._dompc._isLoop ? "WEBRTC_ICE_SUCCESS_RATE" : "LOOP_ICE_SUCCESS_RATE";

Not sure we need a var for something used once, but that's a style nit, and it's probably easier to read (though 'id' is pretty generic a name).

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8691548 [details]
MozReview Request: Bug 1227708 - Differentiate ICE_SUCCESS_RATE telemetry for loop vs webrtc

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/26135/diff/1-2/

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Differentiate ICE_SUCCESS_RATE telemetry for loop vs webrtc

un-bitrotted; will land when the tree opens unless the sheriffs get it first

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f1daf997be9e

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f1daf997be9e