Closed Bug 1227708 Opened 6 years ago Closed 6 years ago

Differentiate ICE_SUCCESS_RATE telemetry for loop vs webrtc

Categories

(Core :: WebRTC, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed
Blocking Flags:

People

(Reporter: jib, Assigned: jib)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Histograms already exist: "WEBRTC_ICE_SUCCESS_RATE" and "LOOP_ICE_SUCCESS_RATE".
Bug 1227708 - Differentiate ICE_SUCCESS_RATE telemetry for loop vs webrtc
Attachment #8691548 - Flags: review?(rjesup)
Assignee: nobody → jib
Attachment #8691548 - Flags: review?(rjesup) → review+
Comment on attachment 8691548 [details]
MozReview Request: Bug 1227708 - Differentiate ICE_SUCCESS_RATE telemetry for loop vs webrtc

https://reviewboard.mozilla.org/r/26135/#review23931

::: dom/media/PeerConnection.js:1328
(Diff revision 1)
> -    var histogram = Services.telemetry.getHistogramById("WEBRTC_ICE_SUCCESS_RATE");
> +    var id = this._dompc._isLoop ? "WEBRTC_ICE_SUCCESS_RATE" : "LOOP_ICE_SUCCESS_RATE";

Not sure we need a var for something used once, but that's a style nit, and it's probably easier to read (though 'id' is pretty generic a name).
Comment on attachment 8691548 [details]
MozReview Request: Bug 1227708 - Differentiate ICE_SUCCESS_RATE telemetry for loop vs webrtc

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/26135/diff/1-2/
backlog: --- → webrtc/webaudio+
Rank: 15
Priority: -- → P1
un-bitrotted; will land when the tree opens unless the sheriffs get it first
https://hg.mozilla.org/mozilla-central/rev/f1daf997be9e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Blocks: 1179513
You need to log in before you can comment on or make changes to this bug.