1227717 - Tweak the margin-end on the gear button on Windows to better align with the alert close button

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

The center of the gear should align with the center of the crosshairs of the X for the close button.

Comment 1

[Matthew N. [:MattN]]

Comment on attachment 8691549 [details] [diff] [review]
Patch

Review of attachment 8691549 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

::: toolkit/themes/windows/global/alerts/alert.css
@@ +30,5 @@
>    border: none !important;
>  }
>  
> +#alertSettings {
> +  margin-inline-end: 3px;

Isn't this fragile? And are the other 2 OSs not affected?

Comment 2

[Matthew N. [:MattN]]

(In reply to Matthew N. [:MattN] from comment #1)
> rs=me

Ignore that for now

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Windows uses a larger sized close button than the other OSes.

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 8691549 [details] [diff] [review]
Patch

Review of attachment 8691549 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/themes/windows/global/alerts/alert.css
@@ +30,5 @@
>    border: none !important;
>  }
>  
> +#alertSettings {
> +  margin-inline-end: 3px;

> Windows uses a larger sized close button than the other OSes.

Please put that in a comment above this property. e.g. "align the centers of the larger Windows close button with the settings gear".

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/f39db2865764809d45ea45f70e1ea0d56bdcc082
Bug 1227717 - Tweak the margin-end on the gear button on Windows to better align with the alert close button. r=MattN

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f39db2865764

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8691549 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: new feature and polish work for push notifications released in 44
[User impact if declined]: gear button looking out of place on windows
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: none, small css change
[String/UUID change made/needed]: none

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8691549 [details] [diff] [review]
Patch

Aurora44+, push notifications related low risk change.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/221ed303e8f1

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/221ed303e8f1