Closed Bug 1227717 Opened 7 years ago Closed 7 years ago

Tweak the margin-end on the gear button on Windows to better align with the alert close button

Categories

(Core :: DOM: Push Notifications, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox44 --- fixed
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
The center of the gear should align with the center of the crosshairs of the X for the close button.
Attachment #8691549 - Flags: review?(MattN+bmo)
Comment on attachment 8691549 [details] [diff] [review]
Patch

Review of attachment 8691549 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

::: toolkit/themes/windows/global/alerts/alert.css
@@ +30,5 @@
>    border: none !important;
>  }
>  
> +#alertSettings {
> +  margin-inline-end: 3px;

Isn't this fragile? And are the other 2 OSs not affected?
(In reply to Matthew N. [:MattN] from comment #1)
> rs=me

Ignore that for now
Windows uses a larger sized close button than the other OSes.
Comment on attachment 8691549 [details] [diff] [review]
Patch

Review of attachment 8691549 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/themes/windows/global/alerts/alert.css
@@ +30,5 @@
>    border: none !important;
>  }
>  
> +#alertSettings {
> +  margin-inline-end: 3px;

> Windows uses a larger sized close button than the other OSes.

Please put that in a comment above this property. e.g. "align the centers of the larger Windows close button with the settings gear".
Attachment #8691549 - Flags: review?(MattN+bmo) → review+
https://hg.mozilla.org/integration/fx-team/rev/f39db2865764809d45ea45f70e1ea0d56bdcc082
Bug 1227717 - Tweak the margin-end on the gear button on Windows to better align with the alert close button. r=MattN
https://hg.mozilla.org/mozilla-central/rev/f39db2865764
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Comment on attachment 8691549 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: new feature and polish work for push notifications released in 44
[User impact if declined]: gear button looking out of place on windows
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: none, small css change
[String/UUID change made/needed]: none
Attachment #8691549 - Flags: approval-mozilla-aurora?
Comment on attachment 8691549 [details] [diff] [review]
Patch

Aurora44+, push notifications related low risk change.
Attachment #8691549 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.