1227728 - Possible race condition when queuing native calls through GeckoThread

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

When queuing native calls through GeckoThread, there can be a race condition such that earlier queued calls are flushed after a later call is made, thus breaking the correct order of calls.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Properly order queued native calls (v1)

Right now, code that queues native calls through GeckoThread can
encounter a race condition, after the GeckoThread state changes but
before we flush the existing queued calls.  In that case, the new call
will be made before existing queued calls are made, and the order of
calls is disrupted. This patch moves flushing existing calls to before
the state changes, to avoid this race condition.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c3a39bddd521

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c3a39bddd521