1227734 - It's possible to accidentally scroll suggestions list down so that blank line appeared

Status: VERIFIED FIXED

Description

[arni2033]

Created attachment 8691589 [details]
screenshot 1 - It's possible to accidentally scroll suggestions list down so that blank line appeared.png

>>>   My Info:   Win7_64, Nightly 45, 32bit, ID 20151120030227
STR:
1.   Focus the searchbar, type "a"   [suggestions list will appear]
2.A) Press Tab key, then Up key
2.B) Move mouse to suggestions list, scroll mousewheel down several times

Result:       
 A blank unselectable line appears in the end of suggestions list.
 If I click it, browser opens a web page with search results for "a"

Expectations: 
 There should be no blank lines in suggestions popup

I'm guessing that it happens because <treechildren> has incorrect height now. It displays 10 suggestions, each tree row has height == 18px, so expected height of <treechildren> in popup is 180px. But it is 179px. Probably that makes it scrollable

Comment 1

[arni2033]

Oh, sorry.
It was regressed between 2015-10-28 and 2015-10-29 by bug 1173715. Pushlog url:
>   https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6cf9efd579290fe27af7a964f20727f92578385d&tochange=b82942655a6364a50060fd310d3caae450ac005a

Comment 3

[Mark Banner (:standard8)]

Created attachment 8805195 [details]
Bug 1227734 - Rework how the top/bottom borders are managed in the search bar popup to avoid a blank search result entry when scrolling.

Review commit: https://reviewboard.mozilla.org/r/88984/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/88984/

Comment 4

[Mark Banner (:standard8)]

I think the revised changes to border management should work fine - definitely look ok on Mac, I've just requested try builds to confirm on Linux/Windows.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8805195 [details]
Bug 1227734 - Rework how the top/bottom borders are managed in the search bar popup to avoid a blank search result entry when scrolling.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/88984/diff/1-2/

Comment 6

[Mark Banner (:standard8)]

For some reason Windows/Linux were missing the border at the bottom of the current search engine. I'm experimenting with adding !important to those rules, I've pushed the patch to mozreview & requested another try build.

Comment 7

[Mark Banner (:standard8)]

I've tested the try build changes and it all looks good to me now, though another pair of eyes on the edge cases would be good.

Comment 8

[Florian Quèze [:florian]]

Comment on attachment 8805195 [details]
Bug 1227734 - Rework how the top/bottom borders are managed in the search bar popup to avoid a blank search result entry when scrolling.

https://reviewboard.mozilla.org/r/88984/#review89634

Makes senses, thanks for figuring out a solution :-).

One case is not handled: websites offering open search plugins (eg https://bugzilla.mozilla.org/ ) when the suggestions tree is collapsed (eg after typing garbage in the search field so that the engine doesn't return any suggestion).

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 8805195 [details]
Bug 1227734 - Rework how the top/bottom borders are managed in the search bar popup to avoid a blank search result entry when scrolling.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/88984/diff/2-3/

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 8805195 [details]
Bug 1227734 - Rework how the top/bottom borders are managed in the search bar popup to avoid a blank search result entry when scrolling.

https://reviewboard.mozilla.org/r/88984/#review89634

Thanks for catching that, I'd missed looking at the add engines section.

Comment 11

[Florian Quèze [:florian]]

Comment on attachment 8805195 [details]
Bug 1227734 - Rework how the top/bottom borders are managed in the search bar popup to avoid a blank search result entry when scrolling.

https://reviewboard.mozilla.org/r/88984/#review89706

Thanks! I tested only on Mac, but given comment 6 and comment 7 I'm confident you tested on the other 2 platforms.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c941a146208
Rework how the top/bottom borders are managed in the search bar popup to avoid a blank search result entry when scrolling. r=florian

Comment 13

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/8c941a146208

Comment 14

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 45.0a1 on Windows 8, 64 Bit !

This bug's fix is verified with latest Developer Edition (Aurora)

Build ID   : 20161118004020
User Agent : Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0
[bugday-20161116]

Comment 15

[Md. Majedul islam]

I have reproduced this bug with Nightly 45.0a1 (2015-11-20) on Ubuntu 16.10, 64 Bit !

This bug's fix is verified with latest Developer Edition (Aurora)

Build ID   : 20161125004006
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0


[testday-20161125]