Closed Bug 1227734 Opened 6 years ago Closed 5 years ago

It's possible to accidentally scroll suggestions list down so that blank line appeared

Categories

(Firefox :: Search, defect, P3)

Product:
Firefox
Component:
Search
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 52
Tracking Flags:
Tracking Status
firefox44 --- affected
firefox45 --- affected
firefox52 --- verified

People

(Reporter: arni2033, Assigned: standard8)

References

(Depends on 1 open bug)

Details

(Keywords: regression, Whiteboard: [fxsearch])

Attachments

(2 files)

screenshot 1 - It's possible to accidentally scroll suggestions list down so that blank line appeared.png
19.35 KB, image/png
Details
Bug 1227734 - Rework how the top/bottom borders are managed in the search bar popup to avoid a blank search result entry when scrolling.
58 bytes, text/x-review-board-request
florian
: review+
Details 
>>>   My Info:   Win7_64, Nightly 45, 32bit, ID 20151120030227
STR:
1.   Focus the searchbar, type "a"   [suggestions list will appear]
2.A) Press Tab key, then Up key
2.B) Move mouse to suggestions list, scroll mousewheel down several times

Result:       
 A blank unselectable line appears in the end of suggestions list.
 If I click it, browser opens a web page with search results for "a"

Expectations: 
 There should be no blank lines in suggestions popup

I'm guessing that it happens because <treechildren> has incorrect height now. It displays 10 suggestions, each tree row has height == 18px, so expected height of <treechildren> in popup is 180px. But it is 179px. Probably that makes it scrollable
Severity: normal → minor
status-firefox44: --- → affected
Priority: -- → P3
See Also: → 1238181
Whiteboard: [fxsearch]
Duplicate of this bug: 1308524
Assignee: nobody → standard8
I think the revised changes to border management should work fine - definitely look ok on Mac, I've just requested try builds to confirm on Linux/Windows.
For some reason Windows/Linux were missing the border at the bottom of the current search engine. I'm experimenting with adding !important to those rules, I've pushed the patch to mozreview & requested another try build.
I've tested the try build changes and it all looks good to me now, though another pair of eyes on the edge cases would be good.
Comment on attachment 8805195 [details]
Bug 1227734 - Rework how the top/bottom borders are managed in the search bar popup to avoid a blank search result entry when scrolling.

https://reviewboard.mozilla.org/r/88984/#review89634

Makes senses, thanks for figuring out a solution :-).

One case is not handled: websites offering open search plugins (eg https://bugzilla.mozilla.org/ ) when the suggestions tree is collapsed (eg after typing garbage in the search field so that the engine doesn't return any suggestion).
Attachment #8805195 - Flags: review?(florian) → review-
Comment on attachment 8805195 [details]
Bug 1227734 - Rework how the top/bottom borders are managed in the search bar popup to avoid a blank search result entry when scrolling.

https://reviewboard.mozilla.org/r/88984/#review89634

Thanks for catching that, I'd missed looking at the add engines section.
Comment on attachment 8805195 [details]
Bug 1227734 - Rework how the top/bottom borders are managed in the search bar popup to avoid a blank search result entry when scrolling.

https://reviewboard.mozilla.org/r/88984/#review89706

Thanks! I tested only on Mac, but given comment 6 and comment 7 I'm confident you tested on the other 2 platforms.
Attachment #8805195 - Flags: review?(florian) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c941a146208
Rework how the top/bottom borders are managed in the search bar popup to avoid a blank search result entry when scrolling. r=florian
https://hg.mozilla.org/mozilla-central/rev/8c941a146208
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
I have reproduced this bug with Nightly 45.0a1 on Windows 8, 64 Bit !

This bug's fix is verified with latest Developer Edition (Aurora)

Build ID   : 20161118004020
User Agent : Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0
[bugday-20161116]
I have reproduced this bug with Nightly 45.0a1 (2015-11-20) on Ubuntu 16.10, 64 Bit !

This bug's fix is verified with latest Developer Edition (Aurora)

Build ID   : 20161125004006
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0


[testday-20161125]
Status: RESOLVED → VERIFIED
status-firefox52: fixed → verified
Depends on: 1327603
You need to log in before you can comment on or make changes to this bug.