Closed
Bug 1227774
Opened 8 years ago
Closed 8 years ago
Encapsulate markCompartments
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
5.40 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
When converting CrossCompartmentKey to a variant, this code really needs to use a functor. However, since the functor needs to take a templated type, we cannot declare it inline. Rather than having the functor be extremely non-local, I'd rather just split this code out into a separate method.
Attachment #8691655 -
Flags: review?(jcoppeard)
Updated•8 years ago
|
Attachment #8691655 -
Flags: review?(jcoppeard) → review+
Assignee | ||
Comment 1•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/13d1f47dabe1eef039da4471e91d8427dfbafe6f Bug 1227774 - Encapsulate markCompartments logic; r=jonco
Comment 2•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/13d1f47dabe1
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•