1227788 - Intermittent test_optional_api_params.html | application crashed [@ mozilla::ErrorResult::~ErrorResult()]

Status: RESOLVED DUPLICATE of bug 1228009

(Core :: DOM: Geolocation, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://treeherder.mozilla.org/logviewer.html#?job_id=3427000&repo=b2g-inbound

Comment 1

[Josh Matthews [:jdm]]

02:11:28     INFO -  210 INFO TEST-OK | dom/tests/mochitest/geolocation/test_optional_api_params.html | took 1679ms
02:11:28     INFO -  *** WIFI GEO: Use request cache:true reason:New req. is GeoIP.
02:11:28     INFO -  ++DOMWINDOW == 55 (0x98025800) [pid = 2620] [serial = 119] [outer = 0x93f87c00]
02:11:28     INFO -  Assertion failure: !Failed(), at ../../dist/include/mozilla/ErrorResult.h:103
02:11:53     INFO -  #01: mozilla::ErrorResult::~ErrorResult() [dom/bindings/ErrorResult.h:103]
02:11:53     INFO -  #02: nsGeolocationRequest::SendLocation(nsIDOMGeoPosition*) [dom/geolocation/nsGeolocation.cpp:663]
02:11:53     INFO -  #03: RequestSendLocationEvent::Run() [dom/geolocation/nsGeolocation.cpp:255]
02:11:53     INFO -  #04: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:964]
02:11:53     INFO -  #05: NS_ProcessNextEvent(nsIThread*, bool) [xpcom/glue/nsThreadUtils.cpp:297]
02:11:53     INFO -  #06: mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:96]
02:11:53     INFO -  #07: MessageLoop::RunInternal() [ipc/chromium/src/base/message_loop.cc:234]
02:11:53     INFO -  #08: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:520]
02:11:53     INFO -  #09: nsBaseAppShell::Run() [widget/nsBaseAppShell.cpp:158]
02:11:53     INFO -  #10: nsAppStartup::Run() [toolkit/components/startup/nsAppStartup.cpp:282]
02:11:53     INFO -  #11: XREMain::XRE_mainRun() [toolkit/xre/nsAppRunner.cpp:4299]
02:11:53     INFO -  #12: XREMain::XRE_main(int, char**, nsXREAppData const*) [toolkit/xre/nsAppRunner.cpp:4391]
02:11:53     INFO -  #13: XRE_main [toolkit/xre/nsAppRunner.cpp:4494]
02:11:54     INFO -  #14: do_main [browser/app/nsBrowserApp.cpp:212]
02:11:54     INFO -  #15: main [browser/app/nsBrowserApp.cpp:354]
02:11:54     INFO -  TEST-INFO | Main app process: exit 11
02:11:54  WARNING -  TEST-UNEXPECTED-FAIL | dom/tests/mochitest/geolocation/test_optional_api_params.html | application terminated with exit code 11

Fascinating! Apparently the HasWebIDLCallback branch is being taken in SendLocation, and something is going wrong when invoking the callback.

Comment 2

[Josh Matthews [:jdm]]

Boris, what's the recommended action to take when the spec doesn't state whether errors from the success or error callbacks should be suppressed or not? What can we do from a C++ method that is called from a runnable?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Huh, I saw this in one of my try pushes and put up a patch already.  ;)

> what's the recommended action to take when the spec doesn't state whether errors from
> the success or error callbacks should be suppressed or not?

Depends on whether the callback is invoked sync or not.  If not sync, all you can do is report to console.

In this case that has already happened; it's just that the caller is being told it happened.  It just needs to explicitly say it plans to do nothing with that information.