1227808 - [TV 2.5] Change the settings of Authorized Devices in Remote Control feature to a simple object instead of a serialized string

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect)

Description

[Luke Chang [:lchang] (inactive)]

In bug 1197749 comment 22, the reviewer reminded us that it's unnecessary to serialize an object in settings. Let's fix it in Gaia as well.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] luke-chang:1227808_tv_remote_control_settings_object > mozilla-b2g:master

Comment 2

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8692401 [details] [review]
[gaia] luke-chang:1227808_tv_remote_control_settings_object > mozilla-b2g:master

Hi Rex,

Please help on this trivial patch. Thanks.

Comment 3

[Luke Chang [:lchang] (inactive)]

[Blocking Requested - why for this release]:

This patch is required according to Gecko's implementation in bug 1197749.

Comment 4

[Luke Chang [:lchang] (inactive)]

tests passed: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=a48f9ebb9ca4edc92ec249827fbdc018e226a749

landed on master: https://github.com/mozilla-b2g/gaia/commit/8653b0647613713be6357484515516b24ee745b6

Comment 5

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8692401 [details] [review]
[gaia] luke-chang:1227808_tv_remote_control_settings_object > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): TV Remote Control feature.
[User impact] if declined: the feature should be broken.
[Testing completed]: yes.
[Risk to taking this patch] (and alternatives if risky): low. It affects the remote control app only.
[String changes made]: N/A

Comment 6

[Josh Cheng [:josh]]

Comment on attachment 8692401 [details] [review]
[gaia] luke-chang:1227808_tv_remote_control_settings_object > mozilla-b2g:master

Approve fro TV 2.5 Remote Control

Comment 7

[Carsten Book [:Tomcat]]

2.5 -> https://github.com/mozilla-b2g/gaia/commit/f63a7347ba0b83ecd984b0c7f36e83eb53784de2