Customize search plugins for zh-CN locale

VERIFIED FIXED

Status

()

Firefox for iOS
General
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: DongShengXue, Assigned: DongShengXue)

Tracking

(Blocks: 1 bug)

unspecified
Other
iOS

Firefox Tracking Flags

(fxios1.4+)

Details

(Whiteboard: [china])

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
Add Baidu, Taobao to search plugins, and set Baidu as default.
Remove Amazon, Twitter, DuckDuckGo
(Assignee)

Updated

2 years ago
Blocks: 1227832
I think this is something we can do right now in the search engine config files.
Whiteboard: [china]
The templates for the search engines are here:

https://github.com/mozilla/firefox-ios/tree/master/Client/Assets/SearchPlugins/zh-CN

Brian, am I right that the changes mentioned in comment #1 can be done by simply modifying those files? Or do we need to do additional work?
Flags: needinfo?(bnicholson)
Same comment as https://bugzilla.mozilla.org/show_bug.cgi?id=1157345#c11. It's fine for now, but we should really start considering a plan to make these changes more scalable. If we were to re-import search engines right now using our scripts, all of these custom changes would be overwritten.

At some point (hopefully soon), we should do a diff of all the changes we've made and move those into the script. That way, they'll get dynamically reapplied every time we do an import.
Flags: needinfo?(bnicholson)
I'm confused why the changes proposed here don't mirror the zh-CN search engines in Android: https://hg.mozilla.org/releases/l10n/mozilla-aurora/zh-CN/file/default/mobile/searchplugins/list.txt

That list shows four engines: google, baidu, twitter, wikipedia-zh-CN. Currently, we have the same list for iOS. Is there an open Android bug for making the same changes?
Flags: needinfo?(dxue)

Comment 5

2 years ago
This is unneccessarily delaying Firefox for users of the Chinese app store. 

Not everyone in China is using the zh-cn locale. Not everyone wants the Chinese search engines.
(Assignee)

Comment 6

2 years ago
(In reply to Brian Nicholson (:bnicholson) from comment #4)
> I'm confused why the changes proposed here don't mirror the zh-CN search
> engines in Android:
> https://hg.mozilla.org/releases/l10n/mozilla-aurora/zh-CN/file/default/
> mobile/searchplugins/list.txt
> 
> That list shows four engines: google, baidu, twitter, wikipedia-zh-CN.
> Currently, we have the same list for iOS. Is there an open Android bug for
> making the same changes?

Hi Brian,

Thank you for reminding, we should update the search plugins to android.
Because we republish the firefox for android in China, we always change the search plugins when we rebuild the android version.
Flags: needinfo?(dxue)
(Assignee)

Comment 7

2 years ago
Created attachment 8692788 [details] [review]
Pull request
Attachment #8692788 - Flags: review?(sarentz)
Comment on attachment 8692788 [details] [review]
Pull request

Looks good to me.
Attachment #8692788 - Flags: review?(sarentz) → review+
https://github.com/mozilla/firefox-ios/commit/c4bc93827c2300f4b4c61494ed55c7b3e7aa44ff
Assignee: nobody → dxue
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Whiteboard: [china] → [china][needsuplift]
tracking-fxios: --- → 1.4+
Created attachment 8698078 [details]
Screen Shot 2015-12-14 at 12.27.34 PM.png
Assignee: dxue → aaron.train

Updated

2 years ago
Assignee: aaron.train → dxue
Status: RESOLVED → VERIFIED
v1.x fb2061c
Whiteboard: [china][needsuplift] → [china]

Comment 12

2 years ago
Verified on Firefox for iOS v1.4(1404).

It works fine both on iOS 8.4.1 and iOS 9.2.
As long as the region is set to China, the default search engine is Baidu as we expect.
You need to log in before you can comment on or make changes to this bug.