Closed Bug 1227852 Opened 5 years ago Closed 5 years ago

Remove --with-dist-dir support from the js build system

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox45 fixed)

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

The option was added in bug 467583 so that both top-level and js/src can use the same $DIST directory.
I actually removed the --with-dist-dir option given to js/src's subconfigure in bug 969164 because $DIST was deduced some other way in that case.
Bug 1227385 exposes new problems with $DIST not having the right value when executing js/src/configure after bug 1224490, but I don't want to re-use --with-dist-dir to fix them. I'd rather remove the option altogether, it was never meant for broad consumption anyways, doesn't appear to be used by anything else.
 And there is no such flag in the top-level build system.
Attachment #8691749 - Flags: review?(mshal) → review+
https://hg.mozilla.org/mozilla-central/rev/532da45ad3b5
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.