Closed
Bug 1227852
Opened 9 years ago
Closed 9 years ago
Remove --with-dist-dir support from the js build system
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox45 fixed)
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(1 file)
2.42 KB,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
The option was added in bug 467583 so that both top-level and js/src can use the same $DIST directory. I actually removed the --with-dist-dir option given to js/src's subconfigure in bug 969164 because $DIST was deduced some other way in that case. Bug 1227385 exposes new problems with $DIST not having the right value when executing js/src/configure after bug 1224490, but I don't want to re-use --with-dist-dir to fix them. I'd rather remove the option altogether, it was never meant for broad consumption anyways, doesn't appear to be used by anything else. And there is no such flag in the top-level build system.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8691749 -
Flags: review?(mshal)
Updated•9 years ago
|
Attachment #8691749 -
Flags: review?(mshal) → review+
Comment 3•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/532da45ad3b5
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•