1227871 - test-specify-reviewers.t is failing

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[:glob ✱]

test-specify-reviewers.t is failing:

@@ -69,50 +69,49 @@
   remote: added 11 changesets with 11 changes to 1 files
   remote: recorded push in pushlog
   submitting 10 changesets for review
-  unrecognized reviewer: test-only

when given the summary: Bug 1 - More stuff; r?romulus, a=test-only

what happened is the old parse_rquestion_reviewers (before bug 1221999) incorrectly returned both 'romulus' and 'test-only' (the rquestion method should only return r? and r= reviewers).

now that test-only isn't returned by parse_rquestion_reviewers, the test case isn't generating the 'unrecognised reviewer' warning.

Comment 1

[:glob ✱]

Attachment: MozReview Request: reviewboard: fix test-specify-reviewers.t (bug 1227871) r?dminor

reviewboard: fix test-specify-reviewers.t (bug 1227871) r?dminor

Fixing parse_rquestion_reviewers to only return r-question reviewers broke this
test.

Comment 2

[Dan Minor [:dminor]]

Comment on attachment 8691795 [details]
MozReview Request: reviewboard: fix test-specify-reviewers.t (bug 1227871) r?dminor

https://reviewboard.mozilla.org/r/26189/#review23569

Thanks for the fix.

Comment 3

[:glob ✱]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/2e919a653f67