1227947 - nsInputStreamPump asserts "OnDataAvailable implementation consumed no data" on erroring observers

Status: NEW

(Core :: Networking, defect, P3)

Description

[Yury Delendik (:yury)]

While working on bug 121809, the crash test at dom/base/crashtests/1154598.xhtml started failing, which is caused by the NS_BINDING_ABORTED returned at OnDataAvailable's writer callback of a stream listener. nsPipeInputStream::ReadSegments at http://mxr.mozilla.org/mozilla-central/source/xpcom/io/nsPipe3.cpp#1281 ignores any errors from such methods and nsInputStreamPump::OnStateTransfer at http://mxr.mozilla.org/mozilla-central/source/netwerk/base/nsInputStreamPump.cpp#626 assumes that no data were read therefore throws an error.

The mozilla-central code contains lots of places where error code means something that nsInputStreamPump shall not ignore (and nsPipeInputStream can process correctly), e.g. http://mxr.mozilla.org/mozilla-central/source/netwerk/base/nsStreamLoader.cpp#136

It's expected: to have a different error/warning message but at nsInputStreamPump level or properly handle the error state of OnDataAvailable's writer callback. I can implement a workaround to silently ignore any incoming data when it's known that request was canceled, but there still will be a problem, e.g. as in nsStreamLoader case, with handling NS_ERROR_OUT_OF_MEMORY.

Comment 1

[Yury Delendik (:yury)]

> While working on bug 121809,

Correction: bug 1218029

Comment 2

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 3

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258