1227954 - Incorrect redirect page result after tapping on signed in account

Status: RESOLVED DUPLICATE of bug 1398283

(Firefox for Android Graveyard :: General, defect)

Description

[u549602]

Environment: 
Device:  (Android );
Build: Nightly 45.0a1 (2015-11-25);

Steps to reproduce:
1. Log in with a valid account
2. Go to Menu - Settings - General - tap on account avatar to access sync menu
3. Tap on "Signed in as (avatar and account)" button 

Expected result:
 If the "Signed in as" section is intended to be a button the redirect should be "manage account" menu

Actual result:
After tapping on the "Signed in as " button, the user is redirected to the change avatar menu.

Please see https://www.youtube.com/watch?v=vffB9nDTEBI&feature=youtu.be  for further details

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I think we can put this up as a mentored polish bug.

Comment 2

[Samuel Mendes]

Hi everyone! I was searching for a second bug and I've ended up here.

I noticed that below button "Signed in as" has a button "Manage account", should both redirect to the same manage account page/menu?

Sorry for any dumb question.

Comment 3

[Vivek Balakrishnan[:vivek]]

Hi Samuel,

Thanks for your interest in this bug. 

First, I would like to give some context on the existing behavior. The idea was to have a similar behavior to that of Desktop where there are two separate actions namely "change profile picture" and "manage accounts". However, unlike in desktop where it is clear that the user can tap of profile icon (tool tip), it is quite difficult to imitate the same behavior in mobile. Further, having only the profile icon clickable may be confusing to mobile user. 

Samuel, You have raised a legitimate question and I would like to clear that up with UX.

@antlam, should we redirect to "manage accounts" page when the user taps on the profile icon preference. In that case shall we drop the redundant "manage accounts" preference?

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Vivek Balakrishnan[:vivek] from comment #3)
> Hi Samuel,
> 
> Thanks for your interest in this bug. 
> 
> First, I would like to give some context on the existing behavior. The idea
> was to have a similar behavior to that of Desktop where there are two
> separate actions namely "change profile picture" and "manage accounts".
> However, unlike in desktop where it is clear that the user can tap of
> profile icon (tool tip), it is quite difficult to imitate the same behavior
> in mobile. Further, having only the profile icon clickable may be confusing
> to mobile user. 
> 
> Samuel, You have raised a legitimate question and I would like to clear that
> up with UX.
> 
> @antlam, should we redirect to "manage accounts" page when the user taps on
> the profile icon preference. In that case shall we drop the redundant
> "manage accounts" preference?

Hm.. I think that suggestion makes sense. I'd prefer to have just 1 button on this page for simplicity sake.
 
Short cutting to changing a display picture is nice, but not necessary. It's confusing on the mobile platform as well because the back button closes the entire tab (rather than dismissing the modal that pops up in the tab). If we remove the "manage" button I'd be concerned about discoverability because its not obvious that the display picture is press-able. Further more, now that we show it earlier in our Settings, it will have inconsistent behaviour.

But before we act on this. Do we have telemetry or any metrics on these two "buttons"?

My suggestion would be to remove the display picture preview here and just have the following as 1 button:

[e-mail]
Manage account

Thoughts?

Comment 5

[Vivek Balakrishnan[:vivek]]

Hi antlam,

As far as I am aware of, we don't have any telemetry or any type metrics data for status activity.
Paging in Nick to correct me if I am wrong and also to opine on the changes (This was Nick's UX design :))

Shall we show username instead of email if available like

User1 
Manage account

Comment 6

[Samuel Mendes]

Attachment: suggestion.jpg

Hi again! Look I'm no designer (you can tell from my attachment).

After your suggestions I thought about that and in the "Settings" page there's already a avatar and username, in order to don't repeat information I suggest that in the "Sync" page we put the username after the label like "SIGNED IN AS: <username>" and remove the menu from the section.

What do you guys think?

Comment 7

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Samuel Mendes from comment #6)
> Created attachment 8698420 [details]
> suggestion.jpg
> 
> Hi again! Look I'm no designer (you can tell from my attachment).
> 
> After your suggestions I thought about that and in the "Settings" page
> there's already a avatar and username, in order to don't repeat information
> I suggest that in the "Sync" page we put the username after the label like
> "SIGNED IN AS: <username>" and remove the menu from the section.
> 
> What do you guys think?

Hey Samuel,

Nice work! that might work too. But I think it's going to be hard to scale for users that have longer emails or smaller phones.

I think repeating information is OK as long as it serves a purpose. Without any other context on that "page" I think it's actually more personal to show the user their name. Furthermore, we can keep consistent with the experience our Desktop counterparts are creating.

(In reply to Vivek Balakrishnan[:vivek] from comment #5)
> Hi antlam,
> 
> As far as I am aware of, we don't have any telemetry or any type metrics
> data for status activity.
> Paging in Nick to correct me if I am wrong and also to opine on the changes
> (This was Nick's UX design :))
> 
> Shall we show username instead of email if available like
> 
> User1 
> Manage account

I think this works. On Desktop, it replaces the email too if there is a display name.

Comment 8

[Nick Alexander :nalexander [he/him]]

(In reply to Anthony Lam (:antlam) from comment #4)
> (In reply to Vivek Balakrishnan[:vivek] from comment #3)
> > Hi Samuel,
> > 
> > Thanks for your interest in this bug. 
> > 
> > First, I would like to give some context on the existing behavior. The idea
> > was to have a similar behavior to that of Desktop where there are two
> > separate actions namely "change profile picture" and "manage accounts".
> > However, unlike in desktop where it is clear that the user can tap of
> > profile icon (tool tip), it is quite difficult to imitate the same behavior
> > in mobile. Further, having only the profile icon clickable may be confusing
> > to mobile user. 
> > 
> > Samuel, You have raised a legitimate question and I would like to clear that
> > up with UX.
> > 
> > @antlam, should we redirect to "manage accounts" page when the user taps on
> > the profile icon preference. In that case shall we drop the redundant
> > "manage accounts" preference?
> 
> Hm.. I think that suggestion makes sense. I'd prefer to have just 1 button
> on this page for simplicity sake.
>  
> Short cutting to changing a display picture is nice, but not necessary. It's
> confusing on the mobile platform as well because the back button closes the
> entire tab (rather than dismissing the modal that pops up in the tab). If we
> remove the "manage" button I'd be concerned about discoverability because
> its not obvious that the display picture is press-able. Further more, now
> that we show it earlier in our Settings, it will have inconsistent behaviour.
> 
> But before we act on this. Do we have telemetry or any metrics on these two
> "buttons"?

No.  We could add some, but we don't have anything yet.

> My suggestion would be to remove the display picture preview here and just
> have the following as 1 button:
> 
> [e-mail]
> Manage account
> 
> Thoughts?

Fine by me.  I'm happy to stop hotlinking to the avatar page, too -- especially since the back button functionality is funky.

Comment 9

[kaleem105]

This bug seems to be forgotten and Since this is my first time I would like to work on this.
I have gone through the discussions and I suggest removing the avatar and have only manage account.

Please do let me know, regarding further actions.

Cheers.

Comment 10

[Kevin Brosnan [Ex-Mozilla]]

Nick is this bug ready for development? Do you have time to mentor this or may be grisha?

Comment 11

[Nick Alexander :nalexander [he/him]]

(In reply to Kevin Brosnan [:kbrosnan] from comment #10)
> Nick is this bug ready for development?

I'd want to verify this is still an issue, since I know the Firefox Accounts team has been doing things to improve links and the back button functionality in the fxa-content-server code.  Kaleem105, can you view the video that Mihai produced and see if this is still a problem with current Nightly Fennec builds?

 Do you have time to mentor this or
> may be grisha?

I don't have time to mentor this, but Grisha might.  Flagging him.

Comment 12

[kaleem105]

Yes I have seen the video and the bug is still there in the fennec build. I did go through the discussions and found some promising alternatives but don't know what decision to take. Like, we can have just the avatar and email where tapping on avatar redirects to change avatar page and tapping on the email redirects to manage accounts and no manage account button as it is redundant. Another alternative is just to display avatar and email and have a manage account button below. So your guidance will be really helpful.

Cheers.

Comment 13

[Nick Alexander :nalexander [he/him]]

(In reply to kaleem105 from comment #12)
> Yes I have seen the video and the bug is still there in the fennec build. I
> did go through the discussions and found some promising alternatives but
> don't know what decision to take. Like, we can have just the avatar and
> email where tapping on avatar redirects to change avatar page and tapping on
> the email redirects to manage accounts and no manage account button as it is
> redundant. Another alternative is just to display avatar and email and have
> a manage account button below. So your guidance will be really helpful.

Let's follow antlam's original suggestion:

> My suggestion would be to remove the display picture preview here and just have the following as 1 button:
> 
> [e-mail]
> Manage account

So: remove the display picture (so sad!), and link to /settings rather than /avatar.

Thanks for your interest!

Comment 14

[:Grisha Kruglov]

Happy to mentor this, Nick. Approach in Comment 4 seems simple and to the point. cc'ing rfeeley on this (sync/fxa UX), for his general awareness.

For some reason I can't modify the "mentors" list :/

Also, the back button behaviour is very ugly. E.g. there's no way to go back to our settings menu once you're looking at the fxa-content tab, which breaks the UI flow. I'm going to file separate tickets to look into improving it.

Comment 15

[:Grisha Kruglov]

Superseded by Bug 1398283