1227960 - Add missing top "Previous" link to Revision History

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: General, enhancement)

Description

[Adrian Aichner [:anaran]]

See these links:

https://developer.mozilla.org/en-US/docs/Mozilla/QA/Automated_testing$revision/934967
https://developer.mozilla.org/en-US/profiles/gbrown
https://developer.mozilla.org/en-US/docs/Mozilla/QA/Automated_testing$compare?to=922081&from=905011
https://developer.mozilla.org/en-US/docs/Mozilla/QA/Automated_testing$revision/922081
https://developer.mozilla.org/en-US/profiles/ato

  referenced from

https://developer.mozilla.org/en-US/docs/Mozilla/QA/Automated_testing$history?limit=all

Details:

Top of history list is missing a Previous link:

         Oct 15, 2015, 12:10:57 AM gbrown Remove references to obsolete Talos-robocop tests.
Previous Sep 22, 2015,  8:33:11 PM ato    update Mn 

Problem:

The missing Previous link on the first line, as also evidenced in "See these links" above, should be

[Previous](https://developer.mozilla.org/en-US/docs/Mozilla/QA/Automated_testing$compare?to=934967&from=922081)

What makes matters worse is that users may deduce the wording of Previous is incorrect (since the first has no Previous) and should be "Next" instead.

All of this can be fixed by adding the missing first Previous link.

http://mzl.la/1vxCDgA

Comment 1

[Adrian Aichner [:anaran]]

Looking at
https://github.com/mozilla/kuma/blob/4838c29847fa6f58935ceefb2a23a641df4e0ad2/kuma/wiki/templates/wiki/list/revisions.html#L55
I can only assume `rev.previous_revision` is false on the current revision.

Does this make sense? Why is this so?

               <div class="revision-list-cell revision-list-prev">
              {% if rev.previous_revision %}
                <a href="{{ url('wiki.compare_revisions', document.slug) }}?to={{ rev.id }}&amp;from={{ rev.previous_revision.id }}" rel="nofollow, noindex">{{ _('Previous') }}</a>
              {% endif %}
              </div>

Comment 2

[Adrian Aichner [:anaran]]

Attachment: https://github.com/mozilla/kuma/pull/3679

Comment 3

[John Whitlock [:jwhitlock]]

The .previous_revision solution was removed in mozilla/kuma#4297 for bug 1269104, and a different method is used to pair revisions with the previous revision that should be more reliable. Please reopen or open a new bug if you see this error again.