[firefox-ui-tests] Add option to run tests in e10s mode

RESOLVED FIXED

Status

Release Engineering
Applications: MozharnessCore
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

unspecified

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
Our firefox ui scripts would need another option (--e10s) to run our tests with out of process mode turned on.
(Assignee)

Comment 1

3 years ago
Created attachment 8692490 [details] [diff] [review]
Patch v1

Patch to allow our tests to be run in e10s mode.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #8692490 - Flags: review?(armenzg)
Attachment #8692490 - Flags: review?(armenzg) → review+

Comment 3

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a93ced84ec3e
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
(Assignee)

Comment 4

3 years ago
The patch as landed caused bustage. :( 

09:41:42    FATAL - Uncaught exception: Traceback (most recent call last):
09:41:42    FATAL -   File "c:\jenkins\workspace\mozilla-central_functional\mozharness\mozharness\base\script.py", line 1719, in run
09:41:42    FATAL -     self.run_action(action)
09:41:42    FATAL -   File "c:\jenkins\workspace\mozilla-central_functional\mozharness\mozharness\base\script.py", line 1661, in run_action
09:41:42    FATAL -     self._possibly_run_method(method_name, error_if_missing=True)
09:41:42    FATAL -   File "c:\jenkins\workspace\mozilla-central_functional\mozharness\mozharness\base\script.py", line 1602, in _possibly_run_method
09:41:42    FATAL -     return getattr(self, method_name)()
09:41:42    FATAL -   File "c:\jenkins\workspace\mozilla-central_functional\mozharness\mozharness\mozilla\testing\firefox_ui_tests.py", line 329, in run_tests
09:41:42    FATAL -     env=self.query_env(),
09:41:42    FATAL -   File "c:\jenkins\workspace\mozilla-central_functional\mozharness\mozharness\mozilla\testing\firefox_ui_tests.py", line 293, in run_test
09:41:42    FATAL -     cmd.extend(self.query_harness_args())
09:41:42    FATAL - TypeError: query_harness_args() takes exactly 2 arguments (1 given)
09:41:42    FATAL - Running post_fatal callback...

Not sure how I was able to oversee that.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 5

3 years ago
Created attachment 8693051 [details] [diff] [review]
Patch v1 (fix bustage)

I could assume that this slipped through when I had a local merge conflict. Note to myself... also test after merge before pushing!
Attachment #8693051 - Flags: review?(armenzg)
Attachment #8693051 - Flags: review?(armenzg) → review+

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1cebd249bf52
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.