1227965 - [firefox-ui-tests] Add option to run tests in e10s mode

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Our firefox ui scripts would need another option (--e10s) to run our tests with out of process mode turned on.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

Patch to allow our tests to be run in e10s mode.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a93ced84ec3e

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a93ced84ec3e

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The patch as landed caused bustage. :( 

09:41:42    FATAL - Uncaught exception: Traceback (most recent call last):
09:41:42    FATAL -   File "c:\jenkins\workspace\mozilla-central_functional\mozharness\mozharness\base\script.py", line 1719, in run
09:41:42    FATAL -     self.run_action(action)
09:41:42    FATAL -   File "c:\jenkins\workspace\mozilla-central_functional\mozharness\mozharness\base\script.py", line 1661, in run_action
09:41:42    FATAL -     self._possibly_run_method(method_name, error_if_missing=True)
09:41:42    FATAL -   File "c:\jenkins\workspace\mozilla-central_functional\mozharness\mozharness\base\script.py", line 1602, in _possibly_run_method
09:41:42    FATAL -     return getattr(self, method_name)()
09:41:42    FATAL -   File "c:\jenkins\workspace\mozilla-central_functional\mozharness\mozharness\mozilla\testing\firefox_ui_tests.py", line 329, in run_tests
09:41:42    FATAL -     env=self.query_env(),
09:41:42    FATAL -   File "c:\jenkins\workspace\mozilla-central_functional\mozharness\mozharness\mozilla\testing\firefox_ui_tests.py", line 293, in run_test
09:41:42    FATAL -     cmd.extend(self.query_harness_args())
09:41:42    FATAL - TypeError: query_harness_args() takes exactly 2 arguments (1 given)
09:41:42    FATAL - Running post_fatal callback...

Not sure how I was able to oversee that.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1 (fix bustage)

I could assume that this slipped through when I had a local merge conflict. Note to myself... also test after merge before pushing!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1cebd249bf52

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1cebd249bf52