1227981 - Test that referencing a DTD from an add-on's inline options works

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Wladimir Palant]

Many extensions localize their inline options file, in fact even the example on https://developer.mozilla.org/en-US/Add-ons/Inline_Options includes a DTD file. With bug 1182546 fixed this no longer works - the inline options file is no longer allowed to load a DTD file.

Steps to reproduce:

1. Install Extension Auto-Installer from https://addons.mozilla.org/en-US/firefox/addon/autoinstaller/ (I would suggest Adblock Plus but it has bigger issues right now).
2. Find Extension Auto-Installer in the Add-ons Manager and click Preferences.

Expected results:

It is possible to set the port that Extension Auto-Installer listens on.

Actual results:

No inline options show up. Error Console shows:

> Security Error: Content at moz-nullprincipal:{6af7d648-5d82-9a44-89db-1a1103251c4a} may not load or link to chrome://autoinstaller/locale/settings.dtd.

> undefined entity settings.xul:10:3

The second error means chrome://autoinstaller/content/settings.xul

Assuming that the Add-ons Manager loads settings.xul via XMLHttpRequest: bug 1226823 comment 15 proposes setting request.channel.owner to system principal as a work-around.

Comment 1

[Dave Townsend [:mossop]]

bz, can you comment if Wladimir's suggested fix is the right one (the add-ons manager does indeed use an XHR to load the add-on's inline options) or should we be waiting for a more general fix from bug 1226869?

Comment 2

[Boris Zbarsky [:bzbarsky]]

The latter.  Christoph is on it.

Comment 3

[Dave Townsend [:mossop]]

Attachment: testcase

Until then here is a testcase for referencing a DTD from inline options. Worked before bug 1182546 landed and fails after.

Comment 4

[Dave Townsend [:mossop]]

Since the fix is happening elsewhere let's morph this to make sure we don't regress this again.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/378ef42875ed

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/378ef42875ed