1228019 - Crash on share menu access

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Aaron Train [:aaronmt]]

Build 24dfac4dd89ffb0433730125c381afbdcad71ba3

Launch browser, visit a site, tap the share menu

2015-11-25 11:54:45.292 Client[27070:16325259] -canOpenURL: failed for URL: "org-appextension-feature-password-management://" - error: "(null)"
2015-11-25 11:54:45.905 Client[27070:16325259] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'Application tried to present modally an active controller <Client.BrowserViewController: 0x7fb2d400e800>.'
*** First throw call stack:
(
	0   CoreFoundation                      0x000000010bfd5f45 __exceptionPreprocess + 165
	1   libobjc.A.dylib                     0x000000010b2f3deb objc_exception_throw + 48
	2   UIKit                               0x000000010ce69e45 -[UIViewController _presentViewController:withAnimationController:completion:] + 5167
	3   UIKit                               0x000000010d6c1581 -[_UIViewControllerTransitionCoordinator _applyBlocks:releaseBlocks:] + 300
	4   UIKit                               0x000000010d6bdde1 -[_UIViewControllerTransitionContext _runAlongsideCompletions] + 149
	5   UIKit                               0x000000010d6bdb34 -[_UIViewControllerTransitionContext completeTransition:] + 117
	6   UIKit                               0x000000010cd6eace -[UIViewAnimationBlockDelegate _didEndBlockAnimation:finished:context:] + 644
	7   UIKit                               0x000000010cd4c9df -[UIViewAnimationState sendDelegateAnimationDidStop:finished:] + 241
	8   UIKit                               0x000000010cd4cd8e -[UIViewAnimationState animationDidStop:finished:] + 80
	9   QuartzCore                          0x000000010cac4fa0 _ZN2CA5Layer23run_animation_callbacksEPv + 308
	10  libdispatch.dylib                   0x000000010f9b849b _dispatch_client_callout + 8
	11  libdispatch.dylib                   0x000000010f9a02af _dispatch_main_queue_callback_4CF + 1738
	12  CoreFoundation                      0x000000010bf362e9 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 9
	13  CoreFoundation                      0x000000010bef78a9 __CFRunLoopRun + 2073
	14  CoreFoundation                      0x000000010bef6e08 CFRunLoopRunSpecific + 488
	15  GraphicsServices                    0x000000010f336ad2 GSEventRunModal + 161
	16  UIKit                               0x000000010ccc430d UIApplicationMain + 171
	17  Client                              0x000000010971b037 main + 487
	18  libdyld.dylib                       0x000000010f9ec92d start + 1

Comment 1

[James Hugman [:jhugman] [@jhugman]]

Caused by duplicated line at 

https://github.com/mozilla/firefox-ios/blob/master/Client/Frontend/Browser/BrowserViewController.swift#L1152 and 
https://github.com/mozilla/firefox-ios/blob/master/Client/Frontend/Browser/BrowserViewController.swift#L1159 

Duplication not present in v1.x. 

https://github.com/mozilla/firefox-ios/blob/v1.x/Client/Frontend/Browser/BrowserViewController.swift#L1107

Comment 2

[James Hugman [:jhugman] [@jhugman]]

Duplicate line introduced 
https://github.com/mozilla/firefox-ios/commit/6e6e3cd3f91ff0e229078c6a5e6e66c0411b9df8#diff-6d1fb0cf203fcd3c299d4ba3f07f21deR1128

introduced by https://bugzilla.mozilla.org/show_bug.cgi?id=1223386

Comment 3

[James Hugman [:jhugman] [@jhugman]]

Attachment: Pull request

Comment 4

[James Hugman [:jhugman] [@jhugman]]

Merged.