1228032 - Toolbox opened in separate window couldn't be resized, moved and closed

Status: VERIFIED FIXED

(DevTools :: General, defect)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 45, 32bit, ID 20151125030231
STR:
1. Open devtools (Ctrl+Shift+I)
2. Click "Show in separate window" button

Result:       
 Toolbox opens in separate window, but there's no close and resize buttons, no title,
 and there's no way to resize, move or close it.

Expectations: 
 The window should look like it used to, or at least: there should be a way to view window title,
 to resize, move and close the window.

It was regressed between 2015-11-23 and 2015-11-24, probably by bug 1226570:
> pushlog_url:   https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=856cffd3910bcb90c681f91ba0acfee9088722c1&tochange=20169c82ed443f7158cf2143223c858647ffe417

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

[Tracking Requested - why for this release]: Not sure I'll get to this before PTO, but we should definitely take a look at this.

Comment 2

[arni2033]

If I open browser toolbox, which is also broken, open frame "toolbox-window.xul" then create a new stylesheet with CSS from chrome://browser/skin/browser.css - then everything's OK.
Looking at the changes made in bug 1226570, probably the goal was to _replace_ stylesheets link, not remove them completely? Currently toolbox window looks as if "-moz-appearance:none" was applied

Comment 3

[:Gijs (he/him)]

I'm pretty sure you want to have chrome://global/skin/[global.css] as a stylesheet for all of these, or you will have a Bad Time.

Comment 4

[Jeff Griffiths (:canuckistani) (:⚡︎)]

I can't repro this on mac. Is it windows only?

Comment 5

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1228032 - restore chrome://global/skin/ where chrome://browser/skin/ was removed, r?jryans

Bug 1228032 - restore chrome://global/skin/ where chrome://browser/skin/ was removed, r?jryans

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8692187 [details]
MozReview Request: Bug 1228032 - restore chrome://global/skin/ where chrome://browser/skin/ was removed, r?jryans

https://reviewboard.mozilla.org/r/26233/#review23643

Okay, since you've confirmed this fixes the issue, we can go with this.

I **believe** we only actually need this in the `toolbox-*-window.xul` files, though.

Comment 7

[:Gijs (he/him)]

Tree's closed, and I need to go sleep.

(In reply to J. Ryan Stinnett [:jryans] (use ni?) (on PTO until Dec. 7) from comment #6)
> Comment on attachment 8692187 [details]
> MozReview Request: Bug 1228032 - restore chrome://global/skin/ where
> chrome://browser/skin/ was removed, r?jryans
> 
> https://reviewboard.mozilla.org/r/26233/#review23643
> 
> Okay, since you've confirmed this fixes the issue, we can go with this.
> 
> I **believe** we only actually need this in the `toolbox-*-window.xul`
> files, though.

I believe the same thing, but I'd rather find out after fixing this for the upcoming nightly. Of course, with the tree closed it's difficult to make sure that happens...

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/5437ff201b3a

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5437ff201b3a

Comment 11

[Rezaul Huque Nayeem]

Reproduced the bug in firefox nightly 45.0a1 (2015-11-25) with windows 10 (64 bit)

Verified as fixed with latest firefox aurora 45.0a2 (Build ID: 20160112004003)

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0