Closed
Bug 1228074
Opened 9 years ago
Closed 9 years ago
Unify the toolbarbutton-1 rules in messenger.css (Windows)
Categories
(Thunderbird :: Theme, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 45.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(1 file, 1 obsolete file)
|
65.05 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
The toolbarbutton-1 rules are now in primaryToolbar.css, addressbook.css and messengercompose.css and are the same. This bug is to remove this copies and move them to messenger.css. This would make future maintenance easier.
|
Assignee | |
Comment 1•9 years ago
|
||
This patch looks huge but is more or less a removal of the code in the three files and move it to messenger.css. I've also added the variables from FX for easier adaption after FX changes.
|
|
Assignee | |
Comment 2•9 years ago
|
||
Updated to tip
Attachment #8692109 -
Attachment is obsolete: true
Attachment #8692109 -
Flags: review?(clokep)
Attachment #8697355 -
Flags: review?(clokep)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8697355 [details] [diff] [review] unifyToolbrbuttonWin.patch Review of attachment 8697355 [details] [diff] [review]: ----------------------------------------------------------------- As best as I can tell, this makes sense. I wasn't quite able to follow every rule, but nothing scares me in here. rs=me!
Attachment #8697355 -
Flags: review?(clokep) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/1414b7c98026491c4c426144077c87fffdf7a069 Bug 1228074 - Unify the toolbabutton-1 styles in messenger.css (Windows). r=clokep
|
|
||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 45.0
You need to log in
before you can comment on or make changes to this bug.
Description
•