Closed Bug 1228074 Opened 4 years ago Closed 4 years ago

Unify the toolbarbutton-1 rules in messenger.css (Windows)

Categories

(Thunderbird :: Theme, defect)

All
Windows
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 45.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

The toolbarbutton-1 rules are now in primaryToolbar.css, addressbook.css and messengercompose.css and are the same. This bug is to remove this copies and move them to messenger.css. This would make future maintenance easier.
Attached patch unifyToolbrbuttonWin.patch (obsolete) — Splinter Review
This patch looks huge but is more or less a removal of the code in the three files and move it to messenger.css.

I've also added the variables from FX for easier adaption after FX changes.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8692109 - Flags: review?(clokep)
Blocks: 1230250
Updated to tip
Attachment #8692109 - Attachment is obsolete: true
Attachment #8692109 - Flags: review?(clokep)
Attachment #8697355 - Flags: review?(clokep)
No longer blocks: 1230250
Comment on attachment 8697355 [details] [diff] [review]
unifyToolbrbuttonWin.patch

Review of attachment 8697355 [details] [diff] [review]:
-----------------------------------------------------------------

As best as I can tell, this makes sense. I wasn't quite able to follow every rule, but nothing scares me in here. rs=me!
Attachment #8697355 - Flags: review?(clokep) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/1414b7c98026491c4c426144077c87fffdf7a069
Bug 1228074 - Unify the toolbabutton-1 styles in messenger.css (Windows). r=clokep
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 45.0
You need to log in before you can comment on or make changes to this bug.