In bug 1203621 we will be releasing mozhginfo (a pushlog client). This is some follow up work. From gps: > It feels weird that the above method sorts oldest to newest and this one is > newest to oldest. I'd be consistent, probably oldest to newest. https://github.com/armenzg/version-control-tools/pull/1#discussion-diff-45653371
Hi I do some address in here (https://github.com/MikeLing/version-control-tools/commit/ededd43cc81bdefead6d14523ee0fbfea05d1f1b), but I found I can't create a PR because that will commit whole pushlog module include again. It seems like we don't have the pushlog module in that vct codebase, so it will commit again. I could I fix that?
Does it work if you do the PR against the official Git repo? My repo is currently out of date.
You can also attach the diff in here and use bugzilla as our reviewing tool.
Created attachment 8694565 [details] [review] PR for bug 1228097 Hmm, my PR somehow commit to the mozilla/vct after I compare with official repo. Not sure if it's ok with that. Let me ask feedback instead of ask review for it for now ;)
Attachment #8694565 - Flags: feedback?(armenzg)
Are you trying to say that the PR is against the official mozilla/vct repo? yes, that is fine. I believe the patch is good to go but when you work on https://github.com/mozilla/mozilla_ci_tools/issues/396 you will need to make sure that we take into account this reversal.
Attachment #8694565 - Flags: feedback?(armenzg) → feedback+
You need to log in before you can comment on or make changes to this bug.