screenshot 1 - First suggestion is wrong when I'm searching for [space][keyword][space][search term].png
110.01 KB, image/png
59 bytes, text/x-review-board-request
>>> My Info: Win7_64, Nightly 45, 32bit, ID 20151125030231 STR: 1. Open about:preferences#search , set keyword "bng" for Bing 2. Type " bng test" in urlbar 3. Press Enter. Result: After Step 2 the first suggestion says "test - Search with Bing" After Step 3 browser opens a page with Yahoo! search results for " bng test" Expectations: I agree with what happens after Step 3, because this hack looks like the only way to search for some text that starts with a keyword. And I expect the first suggestion to be "bng test - Search with [default engine]" However, if the plan is to allow user search for "bng test" if Shift is pressed, then I'm not sure about how expected is result of Step 3. Anyway, results after Steps 2 and 3 do not match each other
yeah, this is a bug. We can either ignore the space and run a keyword query, or run a search. Honestly I think a prefix space like that one followed by a keyword leaves no doubts the user wanted to use the keyword but mistakenly typed a space, so we should just ignore the space.
Priority: -- → P2
This is now WFM, I'll just add a test.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
I suspect it was fixed when we made navigation respect what is in the Address Bar, rather than guessing.
Comment on attachment 8943548 [details] Bug 1228111 - Tests that keywords in Address Bar can be prefixed by spaces. https://reviewboard.mozilla.org/r/213896/#review219890
Attachment #8943548 - Flags: review?(adw) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/2cf4c4fc0763 Tests that keywords in Address Bar can be prefixed by spaces. r=adw
I have reproduced this bug with Nightly 45.0a1 (2015-11-25) on Windows 10 , 64 Bit ! This bug's fix is Verified with latest Beta ! Build ID 20180215111455 User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
QA Whiteboard: [testday-20180216]
This bug is fixed on the latest Nightly 60.0a1 (2018-02-19) under Windows 10 x64, macOS 10.13 and Ubuntu 16.04 x64. Based on my testing and the one described in comment 8, I will mark this bug as verified fixed.
You need to log in before you can comment on or make changes to this bug.