1228123 - E-mail app keyboard pops out and disappears when you share an image from the gallery app.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[[:VladimirBelonenko]]

Attachment: logcat_20151125_1331.txt

Description:
User shares an image with E-mail and when E-mail app opens up keyboard appears and disappears automatically. Going back to Gallery keyboard appears briefly.

Repro Steps:
1) Update a Aries to 20150929110451
2) Open Gallery app.
3) Select image
4) Share it with E-mail.
5) Observe that inside the Email-app keyboard pops out and disappear.

Actual:
E-mail page keyboard appears briefly.

Expected:
During transition, when you share an image with E-mail. Keyboard shouldn't pop out automatically.

Environmental Variables:
Device: Aries Master 2.6 kk full flash
Build ID: 20151125131311
Gaia: 9eca89f04628c99226e0d18c15d5ae11b71af0cf
Gecko: 1835baed2a38429a3cc301d21778a113d3a9e7d8
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Notes: When going back from E-mail app to Gallery keyboard also briefly appears.

Repro frequency: 3/3
See attached: video clip and logcat

Comment 1

[[:VladimirBelonenko]]

This issue does not occurs on Flame 2.6, Flame 2.5 and Flame 2.2
Result: During transition, when you share an image with E-mail. Keyboard pops out automatically and did not disappear

Environmental Variables:
Device: Flame 2.6 kk full flash
Build ID: 20151125030226
Gaia: 37250b125e0db6966875d3b37b117f6d9b76cbc0
Gecko: 099f695d31326c39595264c34988a0f4b7cbc698
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Environmental Variables:
Device: Flame 2.5 kk full flash
Build ID: 20151125122518
Gaia: 93b8bf2de3258c25199d97036c50a87667059148
Gecko: 913818c231658f959ce779ce2763ddb864024057
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 44.0a2
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Environmental Variables:
Device: Flame 2.2 kk full flash
Build ID: 20151125032502
Gaia: 885647d92208fb67574ced44004ab2f29d23cb45
Gecko: 462d8e9208ea
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

Can we verify that this only occurs on Aries? Also, let's see if this is a recent regression.

Comment 3

[Sxean Lee-David [:sxean]]

No Repro per following build: 

RESULT: When share an Image from the Gallery via email, the keyboard does not pop up automatically. The keyboard will only display when you tap the text input areas. 


Environmental Variables:
Device: Aries 2.6
BuildID: 20151211115227
Gaia: d886e152b42e557db612470d3417fe2947cbdeee
Gecko: 754b4805a65cab4f3aca99899227acc44ba4fb20
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Leaving QA wanted for others to try.

Comment 4

[Pi Wei Cheng [:piwei] (inactive)]

I found the steps for this bug. And I'm pretty sure this is how reporter ran into bug 1226419 too, because once it starts to occur, it continues occurring until you kill those windows.

STR:
0) Connect to internet, and there's an image in Gallery
1) Go into Gallery, tap to view a picture > tap share button > E-mail
2) On the Email New Account page, press Home button
3) Go back to Gallery, and repeat step 1 again

- Bug occurs.

Note that at step 2 I can substitute going Home to bringing up Task Manager, then return to Email app again - the symptoms seem exactly the same: keyboard comes up then disappears. But I feel that with Task Manager involved it'll turn out to be the same as bug 1226721.

This is reproducible on central on Flame as well as Aries.

Device: Flame 2.6
BuildID: 20151211030233
Gaia: d886e152b42e557db612470d3417fe2947cbdeee
Gecko: 754b4805a65cab4f3aca99899227acc44ba4fb20
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Device: Aries 2.6
BuildID: 20151211115227
Gaia: d886e152b42e557db612470d3417fe2947cbdeee
Gecko: 754b4805a65cab4f3aca99899227acc44ba4fb20
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

---------

With the same steps, this is NOT reproducible on Flame 2.5. Keyboard correctly comes up after step 3.

Device: Flame 2.5
BuildID: 20151211164817
Gaia: 062e0fa48c1b5d5156f6911a5a4519128fac3231
Gecko: ded0306e0d78528cdcb237c8b05543390f10ec96
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 44.0a2 (2.5) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Comment 5

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Let's verify this is the same window as bug 1226721, and if not find the window for this issue.

Comment 6

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working
Device: Flame 2.6
BuildID: 20151110022434
Gaia: 93ee67c1b886aab107999307cc1fd9177cc1f83c
Gecko: eeb80d0df72ffc3d0d1322aad64d0bfbf6c19d91
Version: 45.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

First Broken
Device: Flame 2.6
BuildID: 20151110025736
Gaia: ad79017bbab3229a02c49cd4cd0c8401e72fc640
Gecko: 3eafe1254d015e1d851ab29ba44b377cfaed52cf
Version: 45.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Last Working Gaia First Broken Gecko - no repro
Gaia: 93ee67c1b886aab107999307cc1fd9177cc1f83c
Gecko: 3eafe1254d015e1d851ab29ba44b377cfaed52cf

Last Working Gecko First Broken Gaia - repro
Gaia: ad79017bbab3229a02c49cd4cd0c8401e72fc640
Gecko: eeb80d0df72ffc3d0d1322aad64d0bfbf6c19d91

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/93ee67c1b886aab107999307cc1fd9177cc1f83c...ad79017bbab3229a02c49cd4cd0c8401e72fc640

This issue is caused by changes made in Bug 1221377

Comment 7

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Alberto the changes from bug 1221377 seem to have caused this issue.  Can you please take a look?

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1228123-sms-kb > mozilla-b2g:master

Comment 9

[Alberto Pastor [:albertopq]]

Comment on attachment 8698076 [details] [review]
[gaia] albertopq:1228123-sms-kb > mozilla-b2g:master

Etienne, it seems I messed it up a little bit fixing this comment:

https://github.com/mozilla-b2g/gaia/pull/33020#discussion-diff-44264845

So I added some events for knowing when canceling/choosing an activity, and block the keyboard when that happens.

Could you please take a look? Thanks!

Comment 10

[Etienne Segonzac (:etienne)]

Comment on attachment 8698076 [details] [review]
[gaia] albertopq:1228123-sms-kb > mozilla-b2g:master

Looks better to me :) Thanks!

Comment 11

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/578c972114e6ad0b3284515b0d29c9d72073961a

Comment 12

[Shally Li（leave from Mozilla）]

Hi Alberto,

    This bug has been verified as "Fail" on the latest build of Flame master and Aries KK master by the STR in comment 4. Could you please help to take a look?

Thank you very much.


--------------------------------------------------------------------------------------------------
Actual results: E-mail app keyboard pops out and then immediately disappears when you share an image from Gallery app.
See attachment: verify_fail_Flame_master.3gp
Reproduce rate: 10/10


Device: Flame master_512mb (Fail)
Build ID               20151220150206
Gaia Revision          d069027f9af6f835ef869f1f01b52339e5a3f423
Gaia Date              2015-12-18 08:50:41
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/388bdc46ba51ee31da8b8abe977e0ca38d117434
Gecko Version          46.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151220.191933
Firmware Date          Sun Dec 20 19:19:45 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master (Fail)
Build ID               20151219131630
Gaia Revision          d069027f9af6f835ef869f1f01b52339e5a3f423
Gaia Date              2015-12-18 08:50:41
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/388bdc46ba51ee31da8b8abe977e0ca38d117434
Gecko Version          46.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151219.123525
Firmware Date          Sat Dec 19 12:35:33 UTC 2015
Bootloader             s1


Notes: 
When tapping the back icon "<" to go back from E-mail app to Gallery, the keyboard also briefly appears.

Comment 13

[Shally Li（leave from Mozilla）]

Attachment: logcat_2046.txt

Comment 14

[Shally Li（leave from Mozilla）]

Attachment: verify_fail_Flame_master.3gp

Comment 15

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1228123-followup > mozilla-b2g:master

Comment 16

[Alberto Pastor [:albertopq]]

This partially fixes the issue, but it seems we are sending events when we shouldn't. Sending a followup soon

Comment 17

[Alberto Pastor [:albertopq]]

Could you please check that the follow up patch fixes the issue? Thanks!

Comment 18

[Shally Li（leave from Mozilla）]

Hi Alberto,

    Sorry to delay. After building with the new patch in comment 15, when you share an image from Gallery app via email, the keyboard pops out and does not disappear (rate: 0/10). Please see "verify_Flame_master(with patch).3gp", thanks.


Device: Flame master_512mb (pass)
Build ID               20151229092705
Gaia Revision          e7da81e76329031f24794350dc0a4330a7d0c603
Gaia Date              2015-12-28 20:17:07
Gecko Revision         n/a
Gecko Version          46.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.rose.20151228.200757
Firmware Date          2015-12-28 Monday 20:08:37 CST
Bootloader             L1TC000118D0

Comment 19

[Shally Li（leave from Mozilla）]

Attachment: verify_Flame_master(with patch).3gp

Comment 20

[Alberto Pastor [:albertopq]]

Comment on attachment 8700997 [details] [review]
[gaia] albertopq:1228123-followup > mozilla-b2g:master

Etienne, could you take a look to this patch? Thanks!

Comment 21

[Etienne Segonzac (:etienne)]

(In reply to Alberto Pastor [:albertopq] from comment #20)
> Comment on attachment 8700997 [details] [review]
> [gaia] albertopq:1228123-followup > mozilla-b2g:master
> 
> Etienne, could you take a look to this patch? Thanks!

The PR is closed. Is the review still needed? Was there an issue?

Comment 22

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1228123-followup > mozilla-b2g:master

Comment 23

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1228123-followup > mozilla-b2g:master

Comment 24

[Alberto Pastor [:albertopq]]

Comment on attachment 8705585 [details] [review]
[gaia] albertopq:1228123-followup > mozilla-b2g:master

Sorry, I unintentionally removed the remote branch during a cleanup :)

Thanks!

Comment 25

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/59229f2e82f2e841edd99d79cb1c5055260304ea