Closed Bug 1228134 Opened 4 years ago Closed 3 years ago
startup crash in Sp
Create Mutex in Firefox 42
This bug was filed from the Socorro interface and is report bp-8de6be5e-424e-4a05-a452-ecbff2151125. ============================================================= Crashing Thread Frame Module Signature Source 0 sapi.dll SpCreateMutex(int, unsigned short const*, unsigned long) 1 sapi.dll CSpObjectToken::InitFromDataKey(unsigned short const*, unsigned short const*, ISpDataKey*) 2 sapi.dll CSpObjectTokenEnumBuilder::AddTokensFromDataKey(ISpDataKey*, unsigned short const*, unsigned short const*) 3 sapi.dll CSpObjectTokenCategory::InternalEnumTokens(unsigned short const*, unsigned short const*, IEnumSpObjectTokens**, int) 4 sapi.dll CSpObjectTokenCategory::EnumTokens(unsigned short const*, unsigned short const*, IEnumSpObjectTokens**) 5 xul.dll mozilla::dom::SapiService::RegisterVoices() dom/media/webspeech/synth/windows/SapiService.cpp 6 xul.dll mozilla::dom::SapiService::Init() dom/media/webspeech/synth/windows/SapiService.cpp 7 xul.dll mozilla::dom::SapiService::GetInstance() dom/media/webspeech/synth/windows/SapiService.cpp 8 xul.dll SapiServiceConstructor dom/media/webspeech/synth/windows/SapiModule.cpp 9 xul.dll mozilla::GenericFactory::CreateInstance(nsISupports*, nsID const&, void**) xpcom/glue/GenericFactory.cpp 10 xul.dll nsComponentManagerImpl::CreateInstanceByContractID(char const*, nsISupports*, nsID const&, void**) xpcom/components/nsComponentManager.cpp 11 xul.dll nsComponentManagerImpl::GetServiceByContractID(char const*, nsID const&, void**) xpcom/components/nsComponentManager.cpp 12 xul.dll xul.dll@0x1bba8e3 13 xul.dll nsTHashtable<nsBaseHashtableET<nsCStringHashKey, nsFactoryEntry*> >::s_HashKey(PLDHashTable*, void const*) xpcom/glue/nsTHashtable.h 14 xul.dll nsCOMPtr_base::assign_from_gs_contractid(nsGetServiceByContractID, nsID const&) xpcom/glue/nsCOMPtr.cpp 15 xul.dll nsCOMPtr<nsISupports>::nsCOMPtr<nsISupports>(nsGetServiceByContractID) xpcom/glue/nsCOMPtr.h 16 xul.dll NS_CreateServicesFromCategory(char const*, nsISupports*, char const*) xpcom/components/nsCategoryManager.cpp we had a user in the sumo forum reporting this as a persistent startup crash: https://support.mozilla.org/en-US/questions/1096003 looking at crash data its volume is very low, put it seems to have been introduced by the work in 42 around the webspeechapi in bug 1003457.
Summary: startup crash in SpCreateMutex in FIreofx 42 → startup crash in SpCreateMutex in Firefox 42
But text to speech isn't enabled by default. Hmm, or are we instantiating the service by default? that would be a rather annoying behavior.
Component: DOM → Web Speech
Makoto, Does the service start up even if synth is disabled. Could you make sense of this stack trace?
Humm, I have no idea why Enumeration crashes, but I forget checking webspeech.enabled on Windows backend. So I can fix it on Firefox 42-44 as default setting. That patch is coming.
Comment on attachment 8692321 [details] [diff] [review] Should check media.webspeech.synth.enabled on Windows SAPI backend I forget checking media.webspeech.synth.enabled prefs on Windows backend. WebSpeech is disabled until Firefox 44, we should check it. But this bug is leave-open state since Firefox 45 turns on this feature. I am still investigating.
Attachment #8692321 - Flags: review?(eitan)
Attachment #8692321 - Flags: review?(eitan) → review+
Comment on attachment 8692321 [details] [diff] [review] Should check media.webspeech.synth.enabled on Windows SAPI backend Approval Request Comment [Feature/regressing bug #]: Bug 1003457 [User impact if declined]: Although I cannot reproduce this, crash reporter reports a few user meets startup crash on Firefox 42. Web Speech Synthesis API isn't turned off Firefox 43 and 44 as default. So this XPCOM service for speech synthesis shouldn't be run, but it runs unfortunately. [Describe test coverage new/current, TreeHerder]: Landed on m-c [Risks and why]: No. Web Speech Synthesis API isn't turned off Firefox 43 and 44 as default. So I add checking perfs for it. [String/UUID change made/needed]: N/A
Comment on attachment 8692321 [details] [diff] [review] Should check media.webspeech.synth.enabled on Windows SAPI backend Approved for uplift to aurora and beta, small fix for text to speech crash.
adding tracking for 43-44 so that we catch this if it reopens or doesn't land.
Any news here? :)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #13) > Any news here? :) Nothing. But WebSpeech synthesis is tuned on Nightly, but I cannot find this crash.
Firefox 49 is released with speech synthesis API, but there is no same crash signature. So I will close this as fixed.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Removing leave-open keyword from resolved bugs, per :sylvestre.
You need to log in before you can comment on or make changes to this bug.