Closed Bug 1228144 Opened 9 years ago Closed 9 years ago

Time format changes after changing date in FTU.

Categories

(Firefox OS Graveyard :: Gaia::First Time Experience, defect, P2)

Product:
Firefox OS Graveyard
Component:
Gaia::First Time Experience
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(b2g-v2.5 verified, b2g-master verified)

Status:
VERIFIED FIXED
Milestone:
2.6 S2 - 12/4
Tracking Flags:
Tracking Status
b2g-v2.5 --- verified
b2g-master --- verified

People

(Reporter: AdamA, Assigned: sfoster)

References

(
URL
)

Details

(Whiteboard: [2.6-Daily-Testing][Spark])

Attachments

(3 files)

logcat
2.04 KB, text/plain
Details
[gaia] sfoster:ftu-date-format-bug-1228144 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
zbraniecki
: review+
mpotharaju
: approval-gaia-v2.5+
Details | Review
verified_Aries_master.3gp
1.59 MB, video/3gpp
Details
Attached file logcat — 
Description:
When the user first encounters the time page in the FTU the time format will be "MM/DD/YEAR" but if the date is changed the time format will be "YEAR-MM-DD".

Prerequisite:
the date time screen will appear when there is no sim present.

Repro Steps:
1) Update a Aries to 20151125130040
2) Proceed to Date and time page
3) Change date
4) Observe date format

Actual:
The date format changes after changing date

Expected:
It is expected that the format remains the same when date changes

Environmental Variables:
Device: Aries 2.6 [Full Flash]
Build ID: 20151125130040
Gaia: 9eca89f04628c99226e0d18c15d5ae11b71af0cf
Gecko: 1835baed2a38429a3cc301d21778a113d3a9e7d8
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Repro frequency: 10/10
See attached: video clip, logcat
This issue DOES occur on Flame 2.6 and Flame 2.5.

Environmental Variables:
Device: FlameKK 2.6 [Full Flash][512mb]
BuildID: 20151125030226
Gaia: 37250b125e0db6966875d3b37b117f6d9b76cbc0
Gecko: 099f695d31326c39595264c34988a0f4b7cbc698
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Device: FlameKK 2.5 [Full Flash][512mb]
BuildID: 20151125122518
Gaia: 93b8bf2de3258c25199d97036c50a87667059148
Gecko: 913818c231658f959ce779ce2763ddb864024057
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 44.0a2 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Result:
The date format changes after changing date
------------------------------------
In Flame 2.2. the date is in "YEAR-MM-DD" format without changing the date.
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Alison, can you take a look at this please?
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker) → needinfo?(ashiue)
Hi Sam,

Could you please help to check this issue? Thanks you.
Flags: needinfo?(ashiue) → needinfo?(sfoster)
Comment on attachment 8693671 [details] [review]
[gaia] sfoster:ftu-date-format-bug-1228144 > mozilla-b2g:master

Looks like this was just overlooked in Bug 1197383.
Flags: needinfo?(sfoster)
Attachment #8693671 - Flags: review?(gandalf)
Comment on attachment 8693671 [details] [review]
[gaia] sfoster:ftu-date-format-bug-1228144 > mozilla-b2g:master

r+
Attachment #8693671 - Flags: review?(gandalf) → review+
This is subtle with en-US (or maybe that's just me as I'm used to mentally translating US-format dates so I didn't notice at first), but might be more of a problem with other locales. Suggesting p2 and we nominate for uplift.
Assignee: nobody → sfoster
Priority: -- → P2
Target Milestone: --- → 2.6 S2 - 12/4
Merged to master: https://github.com/mozilla-b2g/gaia/commit/538c96ab7f17adbbd15b82f750e7247c5685e831
Status: NEW → RESOLVED
Closed: 9 years ago
status-b2g-master: affected → fixed
Resolution: --- → FIXED
Comment on attachment 8693671 [details] [review]
[gaia] sfoster:ftu-date-format-bug-1228144 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Overlooked instance from bug 1204152
[User impact] if declined: Date format is inconsistent with chosen locale, and changes when date/time is adjusted
[Testing completed]: Manually on master
[Risk to taking this patch] (and alternatives if risky): Low risk, is 1 line change applying the same pattern currently used in date-update function
[String changes made]: None
Attachment #8693671 - Flags: approval-gaia-v2.5?
This bug has been verified as "pass" on the latest build of Flame master and Aries KK master by the STR in comment 0.

Actual results: Time format does not change after changing date in FTU.
See attachment: verified_Aries_master.3gp
Reproduce rate: 0/10


Device: Flame KK master_512mb (Pass)
Build ID               20151201150223
Gaia Revision          59c8605876736b22acaaed25be00008e452149cb
Gaia Date              2015-12-01 02:58:37
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1003fca97839fdfbfefb89c48c9e05a940bc9fb9
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151201.183010
Firmware Date          Tue Dec  1 18:30:23 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master (Pass)
Build ID               20151202015416
Gaia Revision          7847a3c1b28e039631509978518b36fd3c5f9585
Gaia Date              2015-12-01 18:47:31
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/470f4f8c2b2d6f82e56e161a4b05262c85f55b59
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151202.011126
Firmware Date          Wed Dec  2 01:11:35 UTC 2015
Bootloader             s1
Attachment #8693671 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5?(mpotharaju)
Comment on attachment 8693671 [details] [review]
[gaia] sfoster:ftu-date-format-bug-1228144 > mozilla-b2g:master

Minor fix. Approved for 2.5 uplift. 

Thanks
Attachment #8693671 - Flags: approval-gaia-v2.5?(mpotharaju) → approval-gaia-v2.5+
This bug has been verified as "pass" on the latest build of Flame v2.5 and Aries KK v2.5 by the STR in comment 0.

Actual results: Date format does not change after changing date in FTU.
See above attachment: verified_Aries_master.3gp
Reproduce rate: 0/10


Device: Flame 2.5_512mb user (Pass)
Build ID               20151214083757
Gaia Revision          062e0fa48c1b5d5156f6911a5a4519128fac3231
Gaia Date              2015-12-11 15:06:09
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/d76a9f65b6ba2ab587d3a0fb5119773ba68720a0
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151214.074606
Firmware Date          Mon Dec 14 07:46:17 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 dogfood (Pass)
Build ID               20151214084334
Gaia Revision          062e0fa48c1b5d5156f6911a5a4519128fac3231
Gaia Date              2015-12-11 15:06:09
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/d76a9f65b6ba2ab587d3a0fb5119773ba68720a0
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151214.074854
Firmware Date          Mon Dec 14 07:49:02 UTC 2015
Bootloader             s1
Status: RESOLVED → VERIFIED
status-b2g-v2.5: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: