1228156 - Should be able to reassign alert to a different summary

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[William Lachance (:wlach)]

Sometimes alerts should be associated with a different summary, mostly in the case of downstream merges. Some discussion of this is in bug 1201154.

Comment 1

[William Lachance (:wlach)]

Attachment: PR

Here's an initial stab at a UI for assigning alerts to another summary. I don't expect a thorough review here, but if you have time to take a quick look it would be appreciated.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8695522 [details] [review]
PR

r=me with two follow up bugs filed:
1) validate or clean error when we enter a valid int, but invalid alert id (i.e. 900 and there is no alert 900)
2) a confirmation dialog on the 'unassign'

this is looking great so far!

Comment 3

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/b6908b2140dac534de45da47cb3e5d9db7c87e17
Bug 1228156 - Backend work for updating performance alerts

Specifically, this update creates an API endpoint that allows updating a
"revised" summary id property off each alert. This is intended for the case
where a performance alert was generated against the wrong summary (usually
because of a downstream merge between branches). For now, the API requires the
user to be staff (i.e. a sheriff), otherwise it will generate a 403 denied.

https://github.com/mozilla/treeherder/commit/4452cdf37592d4677ca8d7195c6e5ae8457fd632
Bug 1228156 - Preliminary UI for reassigning perfherder alerts

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/974903eb473669dbf613a7ec408f8591c702b1e7
Bug 1228156 - Add missing file