1228192 - Expose TXT attributes of MDNS records in NsdMulticastDNSManager

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[C.M.Chang[:chunmin]]

To get remote control service via mDNS, we need to use |attributes| from mDNS to get it's controlling page's path. However, it's not exposed on fennec.

Comment 1

[C.M.Chang[:chunmin]]

Using |serviceInfo.getAttributes()|[0] in |NsdMulticastDNSManager.toJSON()|[1] can't get the discovered services because |serviceInfo.getAttributes()|[2] is used to retrieve those attributes set by |serviceInfo.setAttribute()|[4, 5]

[0] http://developer.android.com/reference/android/net/nsd/NsdServiceInfo.html#getAttributes%28%29
[1] https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/mdns/MulticastDNSManager.java#197
[2] https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/net/nsd/NsdServiceInfo.java#164
[3] https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/net/nsd/NsdServiceInfo.java#99
[4] https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/net/nsd/NsdServiceInfo.java#130

Comment 2

[C.M.Chang[:chunmin]]

Now, it's impossible to get |attributes| from mDNS on android platform. The reason is that android's NsdService[0] doesn't retrieve |txtlen| and |txtdata|, which store the |attributes| data, from the receiving packets.
[0] https://android.googlesource.com/platform/frameworks/base/+/master/services/core/java/com/android/server/NsdService.java#472

Comment 3

[C.M.Chang[:chunmin]]

bug 1011340 might provide an alternative way to parse the raw packets, so we might have chances to get the desired data. However, if some android app occupies the same port that we want to use before fennec is launched, then it may not work.

Comment 4

[Gary Chen [:xeonchen]]

Maybe you can try to operate |mdnsd| directly just like what we did on gonk platform?

Comment 5

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.