1228211 - Slim down nsRenderingContext

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Nicholas Nethercote [inactive]]

nsRenderingContext is pretty small, but it can be made even smaller.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Rearrange nsDisplayCanvasBackgroundImage::Paint()

This patch rearranges Paint() so that the next nsRenderingContext is created
via the one-arg constructor rather than via the zero-arg constructor + Init().
This means the SetLineWidth(1.0) call in Init() no longer occurs but that's ok;
it was redundant because 1.0 is the default line width in a new gfxContext.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Remove unused functions in nsRenderingContext

The following functions in nsRenderingContext are unused and this patch removes
them: the zero-arg constructor, the |DrawTarget*| constructor, and both Init()
functions.

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 8692289 [details] [diff] [review]
(part 1) - Rearrange nsDisplayCanvasBackgroundImage::Paint()

Review of attachment 8692289 [details] [diff] [review]:
-----------------------------------------------------------------

Let's try a different reviewer.

Comment 4

[Daniel Holbert [:dholbert]]

Comment on attachment 8692289 [details] [diff] [review]
(part 1) - Rearrange nsDisplayCanvasBackgroundImage::Paint()

Review of attachment 8692289 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 5

[Daniel Holbert [:dholbert]]

Comment on attachment 8692290 [details] [diff] [review]
(part 2) - Remove unused functions in nsRenderingContext

Review of attachment 8692290 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 6

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aa1f17e24472fd17c378be83600d3e324a404398
Bug 1228211 (part 1) - Rearrange nsDisplayCanvasBackgroundImage::Paint(). r=dholbert.

https://hg.mozilla.org/integration/mozilla-inbound/rev/2fb1d26fb62e12badb7a36da5acfdae2629d1d42
Bug 1228211 (part 2) - Remove unused functions in nsRenderingContext. r=dholbert.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/aa1f17e24472
https://hg.mozilla.org/mozilla-central/rev/2fb1d26fb62e