Remove unpolished phone's apps from TV engineering build.

RESOLVED FIXED

Status

Firefox OS
Gaia::TV
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Evelyn Hung, Assigned: Evelyn Hung)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ft:conndevices][partner-cherry-pick])

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

3 years ago
See bug 1222362 comment 2. Let's remove these apps to avoid confusion!
Created attachment 8692302 [details] [review]
[gaia] evelynhung:issue-1228212 > mozilla-b2g:master
(Assignee)

Comment 2

3 years ago
Comment on attachment 8692302 [details] [review]
[gaia] evelynhung:issue-1228212 > mozilla-b2g:master

Keep built-in keyboard so we can type. r=me.
Attachment #8692302 - Flags: review+
(Assignee)

Comment 3

3 years ago
Merged into master:
https://github.com/mozilla-b2g/gaia/commit/75906f9791ad830490c8165604c7696d3d68cc22
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
No longer depends on: 1222362
See Also: → bug 1222362
Created attachment 8692861 [details] [review]
[gaia] begeeben:revert_1228212 > mozilla-b2g:master
Reverted from master:
https://github.com/mozilla-b2g/gaia/commit/1d5a3c8e518e5a98a6848425616da0cb9f313d25

The patch somehow breaks the Firefox Account log in layout and animation.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 8692904 [details] [review]
[gaia] evelynhung:issue-1228212 > mozilla-b2g:master
(Assignee)

Comment 7

3 years ago
Comment on attachment 8692904 [details] [review]
[gaia] evelynhung:issue-1228212 > mozilla-b2g:master

keep apps/default_theme
Attachment #8692904 - Flags: review+
(Assignee)

Comment 8

3 years ago
reland to master:
https://github.com/mozilla-b2g/gaia/commit/18f404cd80c4c542ce54ea8927d53d3320b70b0c
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
Created attachment 8692914 [details] [review]
[gaia] weilonge:seanlee/TVSystem/master/Bug1228212 > mozilla-b2g:master
Attachment #8692914 - Attachment is obsolete: true
Just discovered that settings app is removed by this patch (which I added in bug 1221943). Now we'll need to manually install it while doing test on real device again. :(
(Assignee)

Comment 11

3 years ago
(In reply to Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) from comment #10)
> Just discovered that settings app is removed by this patch (which I added in
> bug 1221943). Now we'll need to manually install it while doing test on real
> device again. :(

Sorry, didn't aware you are using it. If you think it's necessary, feel free to add it back.

Comment 12

3 years ago
Hi Evelyn,
Do you like to have this land on 2.5?
Flags: needinfo?(ehung)

Updated

3 years ago
Whiteboard: [ft:conndevices] → [ft:conndevices][partner-cherry-pick]
(Assignee)

Comment 13

3 years ago
I guess we are fine without it on 2.5, so no for now. Thanks for asking.
Flags: needinfo?(ehung)
You need to log in before you can comment on or make changes to this bug.