Closed Bug 1228212 Opened 4 years ago Closed 4 years ago

Remove unpolished phone's apps from TV engineering build.

Categories

(Firefox OS Graveyard :: Gaia::TV, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jj.evelyn, Assigned: jj.evelyn)

References

Details

(Whiteboard: [ft:conndevices][partner-cherry-pick])

Attachments

(3 files, 1 obsolete file)

See bug 1222362 comment 2. Let's remove these apps to avoid confusion!
Comment on attachment 8692302 [details] [review]
[gaia] evelynhung:issue-1228212 > mozilla-b2g:master

Keep built-in keyboard so we can type. r=me.
Attachment #8692302 - Flags: review+
Merged into master:
https://github.com/mozilla-b2g/gaia/commit/75906f9791ad830490c8165604c7696d3d68cc22
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
No longer depends on: 1222362
See Also: → 1222362
Reverted from master:
https://github.com/mozilla-b2g/gaia/commit/1d5a3c8e518e5a98a6848425616da0cb9f313d25

The patch somehow breaks the Firefox Account log in layout and animation.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8692904 [details] [review]
[gaia] evelynhung:issue-1228212 > mozilla-b2g:master

keep apps/default_theme
Attachment #8692904 - Flags: review+
reland to master:
https://github.com/mozilla-b2g/gaia/commit/18f404cd80c4c542ce54ea8927d53d3320b70b0c
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Attachment #8692914 - Attachment is obsolete: true
Just discovered that settings app is removed by this patch (which I added in bug 1221943). Now we'll need to manually install it while doing test on real device again. :(
(In reply to Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) from comment #10)
> Just discovered that settings app is removed by this patch (which I added in
> bug 1221943). Now we'll need to manually install it while doing test on real
> device again. :(

Sorry, didn't aware you are using it. If you think it's necessary, feel free to add it back.
Hi Evelyn,
Do you like to have this land on 2.5?
Flags: needinfo?(ehung)
Whiteboard: [ft:conndevices] → [ft:conndevices][partner-cherry-pick]
I guess we are fine without it on 2.5, so no for now. Thanks for asking.
Flags: needinfo?(ehung)
You need to log in before you can comment on or make changes to this bug.