Closed Bug 1228236 Opened 9 years ago Closed 9 years ago

[keyboard refactor] Refactor lib and testapp in Gij for follow-up Gip porting

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ralin, Assigned: ralin)

Details

Attachments

(1 file)

[gaia] raylin:1228236-refactor-keyboard-gij > mozilla-b2g:master
46 bytes, text/x-github-pull-request
timdream
: review+
Details | Review 
We need more helper functions and input fields in the test app, before the follow-up Gip to Gij bugs.
Assignee: nobody → ralin
Comment on attachment 8692713 [details] [review]
[gaia] raylin:1228236-refactor-keyboard-gij > mozilla-b2g:master

For the follow-up gip -> gij porting

1. Added helper functions
2. Refactored lib and testapp
3. Rename input_text.js -> text_keyboard_test.js to differentiate between the other test cases

Thanks,
Attachment #8692713 - Flags: review?(timdream)
Refer to https://bugzilla.mozilla.org/show_bug.cgi?id=1219678#c13, this refactoring is filed separately from it first commit. Just marked this bug as fixed.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Attachment #8692713 - Flags: review?(timdream) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: