Closed Bug 1228252 Opened 9 years ago Closed 9 years ago

move openDialog from util.js to panel_utils

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(tracking-b2g:backlog)

Status:
RESOLVED FIXED
Project Flags:
tracking-b2g backlog

People

(Reporter: gasolin, Assigned: gasolin)

References

Details

Attachments

(1 file)

[gaia] gasolin:issue-1228252 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
yzen
: review+
Details | Review 
related bug 1159657, to refactor util.js. The final goal is move it's functionality to related modules
Assignee: nobody → gasolin
tracking-b2g: --- → backlog
Comment on attachment 8692407 [details] [review]
[gaia] gasolin:issue-1228252 > mozilla-b2g:master

Only panel_utils.js use openDialog method now, so we could safely move it into  panel_utils.js
Attachment #8692407 - Flags: review?(yzenevich)
Blocks: 1159657
Comment on attachment 8692407 [details] [review]
[gaia] gasolin:issue-1228252 > mozilla-b2g:master

Looks good, thanks, Fred
Attachment #8692407 - Flags: review?(yzenevich) → review+
merged https://github.com/mozilla-b2g/gaia/commit/e6d4fb147913b79d66d347b51a7ec711fbf67969

thanks!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: